Skip to content

file: fix whitespaces are filtered in the SaveTo method - #260

Merged
unknwon merged 1 commit into
go-ini:masterfrom
ygj6:issue229
Aug 23, 2020
Merged

file: fix whitespaces are filtered in the SaveTo method#260
unknwon merged 1 commit into
go-ini:masterfrom
ygj6:issue229

Conversation

@ygj6

@ygj6 ygj6 commented Aug 19, 2020

Copy link
Copy Markdown
Contributor

What problem should be fixed?

SaveTo method, the whitespaces are missing #229

Have you added test cases to catch the problem?

Yes,here are some test cases.

@codecov

codecov Bot commented Aug 19, 2020

Copy link
Copy Markdown

Codecov Report

Merging #260 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   86.44%   86.45%   +0.01%     
==========================================
  Files           9        9              
  Lines        1888     1890       +2     
==========================================
+ Hits         1632     1634       +2     
  Misses        196      196              
  Partials       60       60              
Impacted Files Coverage Δ
file.go 85.84% <100.00%> (+0.08%) ⬆️

@unknwon unknwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon changed the title file:Fix the problem that whitespaces are filtered in the SaveTo method file: fix whitespaces are filtered in the SaveTo method Aug 23, 2020
@unknwon
unknwon merged commit 31bf7ce into go-ini:master Aug 23, 2020
@unknwon

unknwon commented Aug 23, 2020

Copy link
Copy Markdown
Member

https://github.com/go-ini/ini/releases/tag/v1.60.1 has been tagged for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants