Merged
Conversation
unknwon
requested changes
Sep 3, 2020
Member
unknwon
left a comment
There was a problem hiding this comment.
Thanks! Please see inline comments.
unknwon
reviewed
Sep 4, 2020
Member
unknwon
left a comment
There was a problem hiding this comment.
Thanks for the follow up! Few more styling comments.
unknwon
reviewed
Sep 4, 2020
unknwon
approved these changes
Sep 5, 2020
Member
unknwon
left a comment
There was a problem hiding this comment.
Thank you for keeping this up!
Closed
Member
|
https://github.com/go-ini/ini/releases/tag/v1.61.0 has tagged for this merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem should be fixed?
Short-circuit load #180
Note: When ShortCircuit and Loose are both true, ShortCircuit has priority over Loose.
Have you added test cases to catch the problem?
Yes, all CI pass the test.