Making DefaultSection modifyable to handle aws profile default.#293
Closed
jade-clarke wants to merge 1 commit intogo-ini:masterfrom
jade-clarke:master
Closed
Making DefaultSection modifyable to handle aws profile default.#293jade-clarke wants to merge 1 commit intogo-ini:masterfrom jade-clarke:master
jade-clarke wants to merge 1 commit intogo-ini:masterfrom
jade-clarke:master
Conversation
Contributor
Author
|
This was done to fix this issue: #287 |
Member
|
Hey! This PR was accidentally closed because |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done to fix the handling of aws credential files. If the default section is not modifyable then when the profiles are loaded from the credentials file, an erronious non-existent DEFAULT section is returned as part of the results array. When given the ability to modify DefaultSection and set it to lower case 'default', it loads the credentials as would be expected.