Skip to content

key: add AllowDuplicateShadowValues option - #298

Merged
unknwon merged 2 commits into
go-ini:mainfrom
dwmunster:f-dup-values
Sep 7, 2021
Merged

key: add AllowDuplicateShadowValues option#298
unknwon merged 2 commits into
go-ini:mainfrom
dwmunster:f-dup-values

Conversation

@dwmunster

Copy link
Copy Markdown
Contributor

Copied from #285 since I don't seem to be able to change the target of that one.

What problem should be fixed?

Fixes #284.

Have you added test cases to catch the problem?

Test cases have been added to key_test.go for both the default and new cases.

@codecov

codecov Bot commented Sep 4, 2021

Copy link
Copy Markdown

Codecov Report

Merging #298 (3a1028d) into main (b52868c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   88.10%   88.11%           
=======================================
  Files           9        9           
  Lines        1354     1355    +1     
=======================================
+ Hits         1193     1194    +1     
  Misses         98       98           
  Partials       63       63           

@unknwon unknwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon changed the title Add AllowDuplicateShadowValues option key: add AllowDuplicateShadowValues option Sep 7, 2021
@unknwon
unknwon merged commit 326d24f into go-ini:main Sep 7, 2021
@unknwon

unknwon commented Sep 7, 2021

Copy link
Copy Markdown
Member

https://github.com/go-ini/ini/releases/tag/v1.63.0 has been published for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot Read Duplicate Values for Shadowed Keys

2 participants