Fix nested values can span sections#306
Merged
unknwon merged 2 commits intogo-ini:mainfrom Dec 2, 2021
ravron:ra-nested-empty-value
Merged
Fix nested values can span sections#306unknwon merged 2 commits intogo-ini:mainfrom ravron:ra-nested-empty-value
unknwon merged 2 commits intogo-ini:mainfrom
ravron:ra-nested-empty-value
Conversation
ravron
commented
Oct 29, 2021
| assert.Equal(t, "value3", f.Section("section2").Key("key3").String()) | ||
| }) | ||
|
|
||
| t.Run("no nested values and following sections with indentation", func(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
This is the only test that fails prior to my fix, but I added the other subtests just to have some more comprehensive coverage, since there are currently no nested value tests at all.
Member
|
GitHub Action got stuck and does not run, I'm gonna try close and reopen the PR see if helps. |
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 88.11% 88.21% +0.09%
==========================================
Files 9 9
Lines 1355 1349 -6
==========================================
- Hits 1194 1190 -4
+ Misses 98 96 -2
Partials 63 63 |
Member
|
https://github.com/go-ini/ini/releases/tag/v1.66.2 has been tagged for this merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem should be fixed?
When configured with
AllowNestedValues: true, the parser attempts to parse values "nested" under a key, AWS-style. To trigger this behavior, the parent key must have an empty value, and child keys must be indented. However, if the next value is in a different section, it cannot be a nested value, but the parser can treat it as such anyways. As an example:Before this PR,
key3is treated as a nested value underkey2, andsection2has no keys.Have you added test cases to catch the problem?
Yes, I've added tests that cover the issue and fail on the current tip of
main.