parser: fix line skipping when key is empty#323
Merged
unknwon merged 2 commits intogo-ini:mainfrom May 30, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
==========================================
- Coverage 88.28% 87.98% -0.31%
==========================================
Files 9 9
Lines 1349 1373 +24
==========================================
+ Hits 1191 1208 +17
- Misses 96 99 +3
- Partials 62 66 +4 |
unknwon
requested changes
May 30, 2022
Member
unknwon
left a comment
There was a problem hiding this comment.
Thanks for the PR!
One minor issue.
Member
|
https://github.com/go-ini/ini/releases/tag/v1.66.6 has been tagged for this merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR fixes a scenario where the key name is zero length and
readKeyNameincorrectly handle it. Even if settingSkipUnrecognizableLinesto true wasn't being skipped.Checklist