add NoMultiLineSurroundingQuotes option#331
Open
benbaker76 wants to merge 1 commit intogo-ini:mainfrom
Open
Conversation
aghandri
suggested changes
Nov 21, 2022
There was a problem hiding this comment.
Thank you for suggesting this change, it is indeed a very handy option, especially when used to generate aws config files.
However, the result of your changes still keeps the surrounding double quotes if the value contains leading and trailing white spaces.
Here is the result I obtained:
duration_seconds = xxxxxxx
s3 = "
signature_version = version"To remove these double quotes, I suggest to add the condition on line 467:
} else if !f.options.NoMultiLineSurroundingQuotes && len(strings.TrimSpace(val)) != len(val) {
val = `"` + val + `"`
}The result would be:
duration_seconds = xxxxxxx
s3 =
signature_version = version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Consider the following multi-line ini file:
value1 = some text here some more text here 2Run the following code:
Will output:
Now run:
The output is the same as the original file
value1 = some text here some more text here 2Link to the issue: n/a
Checklist