fix(key): check element instead of slice length in StringsWithShadows - #387
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix(key): check element instead of slice length in StringsWithShadows#387AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
StringsWithShadows used "len(vals) == 0" inside a for-range loop over vals, which is always false when the loop body executes (the loop never runs on empty slices). This meant empty string values were passed through to strings.Split and produced spurious blank entries in results. Changed to iterate with "for _, v := range vals" and check "if v == \"\"" to properly skip individual empty values. Signed-off-by: Kushal Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringsWithShadows used
len(vals) == 0inside afor-rangeloop over vals, which is always false when the loop body executes. This check was intended to skip empty element values but instead checked the entire slice length (dead code pattern).Empty string values were passed through to strings.Split and produced spurious blank entries in results. Changed to iterate with
for _, v := range valsand checkif v == ""to properly skip individual empty values.