Repository navigation
key: keep empty shadows when PreserveEmptyShadows is set - #399
Merged
Merged
Conversation
ValueWithShadows dropped empty assignments, which breaks systemd-style resets. Opt in with LoadOptions.PreserveEmptyShadows. Fixes go-ini#366
…ShadowValues An empty value kept by the option is a reset, so it isn't deduplicated. The name matches AllowDuplicateShadowValues and the v2 option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueWithShadows currently omits empty assignments. That drops systemd-style resets (
Environment=clears prior values).Add opt-in
LoadOptions.PreserveEmptyShadowsso callers can keep empty shadow values without changing the default.Fixes #366