Skip to content

fix(contrib/drivers/dm): support muti-line sql statement (#4163) - #4164

Merged
hailaz merged 3 commits into
gogf:masterfrom
sanrentai:master
Dec 3, 2025
Merged

fix(contrib/drivers/dm): support muti-line sql statement (#4163)#4164
hailaz merged 3 commits into
gogf:masterfrom
sanrentai:master

Conversation

@sanrentai

@sanrentai sanrentai commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@gqcn

gqcn commented Feb 27, 2025

Copy link
Copy Markdown
Member

@sanrentai 你好,你这个改动看起来没有什么问题的,但请提交对应的单测。此外,需要注意,多行的sql支持通常需要底层driver配置项的支持才能打开,因为容易产生sql注入的风险。

@Issues-translate-bot

Copy link
Copy Markdown

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@sanrentai Hello, your changes seem to be nothing wrong, but please submit the corresponding single test. In addition, it should be noted that multi-line SQL support usually requires the support of the underlying driver configuration item to be opened, because it is easy to cause the risk of SQL injection.

@gqcn gqcn added the missing unit testing cases Used in PR, the associated unit testing cases should be committed. label Feb 27, 2025
@hailaz
hailaz merged commit 3912d97 into gogf:master Dec 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing unit testing cases Used in PR, the associated unit testing cases should be committed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants