Revert "feat(database/gdb): Added OmitZero function to filter zero value parameters" - #4818
Merged
Conversation
…lue para…" This reverts commit 6e0ca52.
gqcn
approved these changes
Jul 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously added “OmitZero” functionality in database/gdb, removing both the model options and the underlying zero-value detection helper that supported filtering zero-value parameters in Where/Having and Data handling.
Changes:
- Removed
empty.IsZero(and its unit tests) frominternal/empty. - Removed
OmitZero*model options/bitflags and all related filtering logic fromdatabase/gdb. - Removed MySQL driver integration tests that exercised
OmitZero*behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/empty/empty.go | Removes IsZero helper and its related interface. |
| internal/empty/empty_z_unit_test.go | Removes unit tests for the removed IsZero behavior. |
| database/gdb/gdb_model_utility.go | Removes zero-value filtering for insert/update data maps. |
| database/gdb/gdb_model_select.go | Stops passing OmitZero into where/having formatting. |
| database/gdb/gdb_model_option.go | Removes OmitZero* option constants and public model methods. |
| database/gdb/gdb_model_builder.go | Stops passing OmitZero into builder where formatting. |
| database/gdb/gdb_func.go | Removes OmitZero support from where-holder formatting and helpers. |
| contrib/drivers/mysql/mysql_z_unit_model_test.go | Removes integration tests for OmitZero* model options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
9
to
+13
| const ( | ||
| optionOmitNil = optionOmitNilWhere | optionOmitNilData | ||
| optionOmitEmpty = optionOmitEmptyWhere | optionOmitEmptyData | ||
| optionOmitZero = optionOmitZeroWhere | optionOmitZeroData | ||
| optionOmitNilDataInternal = optionOmitNilData | optionOmitNilDataList // this option is used internally only for ForDao feature. | ||
| optionOmitEmptyWhere = 1 << iota // 8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4713