Conversation
The TimeSince function generates <span title=...> elements for date tooltips, but bluemonday's UGCPolicy strips the title attribute. This causes the tooltip over time-since strings (e.g. "3 weeks later") to not appear in issue views. Create a custom sanitizer policy that extends UGCPolicy to allow the title attribute on span elements. Fixes gogs#8277
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8277
Problem
The
TimeSincefunction generates<span class="time-since" title="...">elements to display date tooltips on hover. However, the template sanitizer usesbluemonday.UGCPolicy()which strips thetitleattribute fromspanelements. This causes the tooltip to silently disappear in issue views where the output passes through theSanitizetemplate function.Solution
Create a custom sanitizer policy that extends
UGCPolicywithAllowAttrs("title").OnElements("span"). This preserves the date tooltip while keeping all other sanitization rules intact.The
titleattribute onspanis safe. It carries only the formatted timestamp thatTimeSincealready generates from trusted internal data, not from user input.