Repository navigation
build(deps): bump github.com/valyala/fasthttp from 1.76.0 to 1.77.0 in the fasthttp-modules group - #4803
Conversation
Bumps the fasthttp-modules group with 1 update: [github.com/valyala/fasthttp](https://github.com/valyala/fasthttp). Updates `github.com/valyala/fasthttp` from 1.76.0 to 1.77.0 - [Release notes](https://github.com/valyala/fasthttp/releases) - [Commits](valyala/fasthttp@v1.76.0...v1.77.0) --- updated-dependencies: - dependency-name: github.com/valyala/fasthttp dependency-version: 1.77.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: fasthttp-modules ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a298712fab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
fasthttp 1.77 sends Content-Range: bytes */<size> with a 416 (RFC 9110 §15.5.17). The If-Range path answered through ctx.Error after fetching the whole file, which wipes the header, so a matching If-Range with an unsatisfiable range lost it. Keep the file server's value: the whole file may be compressed, so its length is the wrong one.
The file server and the byterange wrapper now set it on every 416, so the extra stat per ranged SendFile request only duplicated their work.
|
Pushed 322371d: fasthttp 1.77.0 now sends Generated by Claude Code |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
==========================================
- Coverage 95.83% 95.81% -0.03%
==========================================
Files 153 153
Lines 18610 18589 -21
==========================================
- Hits 17835 17811 -24
- Misses 485 487 +2
- Partials 290 291 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fasthttp 1.77 confines a root on disk: a symbolic link that leaves it, and an absolute link even when it points inside, now gets 404. Pass its AllowSymlinksOutsideRoot through so deployments that link shared assets on purpose can opt back in. The secure default stays.
A status set before SendFile replaced whatever the file server answered, so c.Status(201) turned a 206 into a 201 with a partial body and a 416 into a 201 carrying the error text. It now replaces only a 200. Download and MaxAge no longer put Content-Disposition and Cache-Control on a 416, as the static middleware already does.
Drop the rows that only pinned how fasthttp parses a Range Fiber passes on untouched; both recent fasthttp bumps flipped them. Cover If-Range against an ETag the caller set in the byterange suite, have the static table hit a rule only the wrapper applies, and stop asserting an absent Accept-Ranges on the 416. Bring two comments up to date with fasthttp ignoring several ranges itself.
322371d to
6618b9a
Compare
fasthttp 1.77 confines the file server to its root, and the compressed copy of a file root lies beside the file, outside it, so every request with an Accept-Encoding it could compress for fell through as a miss. A file root serves only itself, so it is not confined.
With a status of 300 or above set before SendFile, the file server still honored Range and If-Modified-Since, so c.Status(404).SendFile answered 304 or 206 since 9f10d7d, and an empty or partial 404 before it. Those fields apply only to a 2xx (RFC 9110 §13.2.1, §14.2): hide them from the file server and put them back afterwards. Download and MaxAge now follow the status that is sent, as in the static middleware.
A link the root confinement refuses is a miss, so a later handler can still serve the path; it is not a 404 by itself. Note that file roots are not confined and that Compress writes copies into a linked directory. Drop a test comment the test no longer checks and keep the static table's want prefix.
Bumps the fasthttp-modules group with 1 update: github.com/valyala/fasthttp.
Updates
github.com/valyala/fasthttpfrom 1.76.0 to 1.77.0Release notes
Sourced from github.com/valyala/fasthttp's releases.
... (truncated)
Commits
61bdcc3fix(fs): send Content-Range with 416 responses (#2502)020e4edfix(cookie): store Set-Cookie without '=' under the key ParseBytes gives it (...33b5261fix(cookie): trim tabs around cookie names, values and attributes (#2500)7e7f8ecfix(cookie): recognize Secure, HttpOnly and Partitioned with a value (#2498)720d20efix(fasthttpproxy): send decoded proxy credentials in Proxy-Authorization (#2...91b4512fix(cookie): ignore an invalid Max-Age attribute instead of failing to parse ...e0f6199Export KeepBodyBuffer on Request and Response (#2451)d9bf5c5fix: detach kept hijacked connections from the request context's reader (#2495)ad21d1bmake PipeConns deadlines interrupt pending reads and writes (#2471)09cba73fix: run hijack handlers under DisableKeepalive and MaxRequestsPerConn (#2494)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions