🐛 bug: fix proxy overwrote the wrong scheme - #2004

thanks for the work, can you look over my comments

thanks for the work, can you look over my comments

In this scenario, addr is a slice reference to the []byte c.fasthttp.Request.Header.requestURI, so when SetRequestURI is executed the requestURI changes causing addr to change as well.

More specifically, for the above example, addr is equivalent to requestURI[1:], so after the requestURI changes from /http://ip-api.com/json to http://ip-api.com/json addr will change from http://ip-api.com/json to ttp://ip-api.com/json, causing SetSchema to fail.

So I think it is necessary to make the above changes.

thanks for the work, can you look over my comments

In this scenario, addr is a slice reference to the []byte c.fasthttp.Request.Header.requestURI, so when SetRequestURI is executed the requestURI changes causing addr to change as well.

More specifically, for the above example, addr is equivalent to requestURI[1:], so after the requestURI changes from /http://ip-api.com/json to http://ip-api.com/json addr will change from http://ip-api.com/json to ttp://ip-api.com/json, causing SetSchema to fail.

yes i know so it should be enough to inject the copy when setting the requestUri

since this removes the link to the variable with the addr, the following change is then no longer necessary

since this removes the link to the variable with the addr, the following change is then no longer necessary

When I use the modifications you mentioned above, I can't pass the test.

In SetRequestURI, h.requestURI = append(h.requestURI[:0], requestURI...) will be executed. Because the resulting []byte is shorter than the original one, it will execute in the original []byte. And no memory will be allocated.

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord