✨ update: tls.ClientHelloInfo in Ctx#2011
Conversation
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
|
I think this method should be in App. Can you move it into the app? |
@efectn Why? I think it must be in context directly, not in App() |
It doesn't have context-specific thing |
tls.ClientHelloInfo, is sent by the browser when the user connects to the website, so I think it should be in context. |
|
Yes the CHI is sent by the client, that's why I put it in the context. |
|
@thomasdseao |
|
@ReneWerner87 That's done : gofiber/docs#271 |
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
This PR is related to a request : v3 (view)
Add the function ClientHelloInfo to the fiber Ctx so everybody can access it from handler.