Skip to content

✨ update: tls.ClientHelloInfo in Ctx#2011

Merged
ReneWerner87 merged 14 commits into
gofiber:masterfrom
thomasdseao:master
Aug 19, 2022
Merged

✨ update: tls.ClientHelloInfo in Ctx#2011
ReneWerner87 merged 14 commits into
gofiber:masterfrom
thomasdseao:master

Conversation

@thomasdseao

Copy link
Copy Markdown
Contributor

This PR is related to a request : v3 (view)

Add the function ClientHelloInfo to the fiber Ctx so everybody can access it from handler.

@welcome

welcome Bot commented Aug 12, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Comment thread app.go Outdated
Comment thread ctx_test.go Outdated
@efectn efectn added this to the v3 milestone Aug 12, 2022
@efectn efectn linked an issue Aug 12, 2022 that may be closed by this pull request
@ReneWerner87 ReneWerner87 removed the v3 label Aug 15, 2022
@ReneWerner87 ReneWerner87 changed the title ✨ v3 (update): tls.ClientHelloInfo in Ctx ✨(update): tls.ClientHelloInfo in Ctx Aug 15, 2022
@efectn

efectn commented Aug 15, 2022

Copy link
Copy Markdown
Member

I think this method should be in App. Can you move it into the app?

@efectn efectn changed the title ✨(update): tls.ClientHelloInfo in Ctx ✨update: tls.ClientHelloInfo in Ctx Aug 15, 2022
@ja3abuser

Copy link
Copy Markdown

I think this method should be in App. Can you move it into the app?

@efectn Why? I think it must be in context directly, not in App()

@efectn

efectn commented Aug 15, 2022

Copy link
Copy Markdown
Member

I think this method should be in App. Can you move it into the app?

@efectn Why? I think it must be in context directly, not in App()

It doesn't have context-specific thing

@ja3abuser

Copy link
Copy Markdown

I think this method should be in App. Can you move it into the app?

@efectn Why? I think it must be in context directly, not in App()

It doesn't have context-specific thing

tls.ClientHelloInfo, is sent by the browser when the user connects to the website, so I think it should be in context.

@thomasdseao

Copy link
Copy Markdown
Contributor Author

Yes the CHI is sent by the client, that's why I put it in the context.
But if you think this is more compliant with Fiber logical to have it in App, I can move it.

@ReneWerner87

Copy link
Copy Markdown
Member

@thomasdseao
can you please add a pull request to our documentation repository so that everyone knows what the point of it is and how to use it?
https://github.com/gofiber/docs/pulls

@thomasdseao

Copy link
Copy Markdown
Contributor Author

@ReneWerner87 That's done : gofiber/docs#271

Comment thread ctx.go Outdated
@efectn efectn changed the title ✨update: tls.ClientHelloInfo in Ctx ✨ update: tls.ClientHelloInfo in Ctx Aug 18, 2022
@ReneWerner87 ReneWerner87 merged commit 2edcf95 into gofiber:master Aug 19, 2022
@welcome

welcome Bot commented Aug 19, 2022

Copy link
Copy Markdown

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 v3 Request: tls.ClientHelloInfo in handlers

4 participants