Skip to content

(cherry-pick) Call /v2/auth/token api to get bearer token for dockerhub adapter - #23208

Merged
stonezdj merged 1 commit into
goharbor:release-2.14.0from
stonezdj:2.14_dockerhub_proxycache
May 8, 2026
Merged

(cherry-pick) Call /v2/auth/token api to get bearer token for dockerhub adapter#23208
stonezdj merged 1 commit into
goharbor:release-2.14.0from
stonezdj:2.14_dockerhub_proxycache

Conversation

@stonezdj

@stonezdj stonezdj commented May 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: stonezdj <stonezdj@gmail.com>
@stonezdj
stonezdj requested a review from a team as a code owner May 7, 2026 11:54
@stonezdj stonezdj changed the title Call /v2/auth/token api to get bearer token for dockerhub adapter (cherry-pick) Call /v2/auth/token api to get bearer token for dockerhub adapter May 7, 2026
@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-2.14.0@b1a0d11). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/pkg/reg/adapter/dockerhub/client.go 23.80% 15 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.14.0   #23208   +/-   ##
=================================================
  Coverage                  ?   65.84%           
=================================================
  Files                     ?     1073           
  Lines                     ?   116248           
  Branches                  ?     2933           
=================================================
  Hits                      ?    76542           
  Misses                    ?    35445           
  Partials                  ?     4261           
Flag Coverage Δ
unittests 65.84% <23.80%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/pkg/reg/adapter/dockerhub/consts.go 36.36% <ø> (ø)
src/pkg/reg/adapter/dockerhub/client.go 29.62% <23.80%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stonezdj
stonezdj enabled auto-merge (squash) May 7, 2026 12:18

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj
stonezdj merged commit a142ab7 into goharbor:release-2.14.0 May 8, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants