Repository navigation
Unit tests action - #5
janzak-dev wants to merge 2 commits into
Conversation
08a9715 to
3a37054
Compare
There was a problem hiding this comment.
This and #6 should be reordered to prevent submitting red stuff:
PR A (Test Robustness): Change the base of PR #6 to target test directly, and limit it to only the Go code changes needed to support parallel execution (handling AlreadyExists for instance creation, exposing dynamic DB names from emulator.Setup, and updating runner_test.go to use them). This PR will be green (verified locally).
PR B (this PR #5): Once PR A is merged, rebase PR #5 on test and update the GHA workflow to include the Spanner emulator service. This PR will then run green on GHA and can be merged.
| run-tests: | ||
| name: 'Run Unit Tests' | ||
| runs-on: 'ubuntu-24.04' | ||
| environment: janzak-dev-test |
There was a problem hiding this comment.
I think we need some other name for the environment 😄
There was a problem hiding this comment.
I will rename this once the environment gets more stable (I have a task for it, I'd rather not deal with this right now).
| pull_request: | ||
| push: | ||
| branches: | ||
| - feature/unit_tests_action |
There was a problem hiding this comment.
This should be updated to the test
There was a problem hiding this comment.
I'll add test branch here.
|
@VLukiantsev I don't see a way to answer your comment directly so I'll leave this here.
Honestly, I would've preferred to submit this scaffolding and then iterate on this branch, fixing batches of tests until everything is green. Such a flow felt pretty natural to me. If you're against have red stuff inside the codebase I can:
What do you think? |
First option LGTM. |
This feature introduces a github action that runs unit tests on demand (and on submissions to this branch)
Currently the full run of a test takes a long while (30-60 minutes) but after applying caching and limiting timeouts to 15 seconds later runs are relatively fast (~5 minutes). It is expected that the test currently fail
You can inspect all runs of that action here https://github.com/google/xmc/actions?query=workflow%3A%22XMC%20Unit%20Tests%22. Additionally I did a preliminary integration with BTX to better view the runs and manage them. You can see them here https://btx.cloud.google.com/ (if you specify a proper GCP project) - however I wasn't able to get the logs to work.
Future improvements:
testbranch