Repository navigation
fix(health_service): fallback db schema version to UNAVAILABLE and format as hyphen in UI - #689
Merged
Merged
Conversation
…rmat as hyphen in UI Update the database schema version error fallback string in health-service from "unknown" to "UNAVAILABLE" when ESS or XID schema versions are unavailable. Update the UI system info card to format unavailable schema versions as "-" using reactive computed signals. TAG=agy CONV=ac2ea8e0-6035-4ee2-8092-f2b96e1c9548
There was a problem hiding this comment.
Code Review
This pull request updates the health service and UI to handle unavailable database schema versions by replacing the "unknown" string with "UNAVAILABLE" in the backend, and displaying a placeholder ("-") with a specific CSS class in the UI. The reviewer suggested extracting the formatting and unavailability check logic in the Angular component into private helper methods to reduce duplication and handle potential falsy values safely.
andrzejfudro
marked this pull request as ready for review
August 31, 2026 16:37
andrzejfudro
enabled auto-merge
September 1, 2026 07:02
janzak-dev
previously approved these changes
Sep 1, 2026
There was a problem hiding this comment.
🤖 Incremental PR Approval
PR author is a code owner and changes since last approval (2 lines) are within the 10-line grace delta.
Preserving prior approval by @janzak-dev on commit 6d8908a.
janzak-dev
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the database schema version error fallback in
cmd/health_service/server.goto"UNAVAILABLE", and update the UI system info card to cleanly format unavailable schema versions as"-"with subdued placeholder styling.Preview
