Skip to content

fix(health_service): fallback db schema version to UNAVAILABLE and format as hyphen in UI - #689

Merged
andrzejfudro merged 5 commits into
mainfrom
fix/health-schema-unavailable-fallback
Sep 1, 2026
Merged

andrzejfudro merged 5 commits into
mainfrom
fix/health-schema-unavailable-fallback

Conversation

@andrzejfudro

@andrzejfudro andrzejfudro commented Aug 31, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Update the database schema version error fallback in cmd/health_service/server.go to "UNAVAILABLE", and update the UI system info card to cleanly format unavailable schema versions as "-" with subdued placeholder styling.

Preview
image

…rmat as hyphen in UI

Update the database schema version error fallback string in health-service from "unknown" to "UNAVAILABLE" when ESS or XID schema versions are unavailable. Update the UI system info card to format unavailable schema versions as "-" using reactive computed signals.

TAG=agy
CONV=ac2ea8e0-6035-4ee2-8092-f2b96e1c9548

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the health service and UI to handle unavailable database schema versions by replacing the "unknown" string with "UNAVAILABLE" in the backend, and displaying a placeholder ("-") with a specific CSS class in the UI. The reviewer suggested extracting the formatting and unavailability check logic in the Angular component into private helper methods to reduce duplication and handle potential falsy values safely.

@andrzejfudro
andrzejfudro marked this pull request as ready for review August 31, 2026 16:37
janzak-dev
janzak-dev previously approved these changes Sep 1, 2026
github-actions[bot]
github-actions Bot previously approved these changes Sep 1, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Incremental PR Approval

PR author is a code owner and changes since last approval (2 lines) are within the 10-line grace delta.

Preserving prior approval by @janzak-dev on commit 6d8908a.

@andrzejfudro
andrzejfudro added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit 0b87e47 Sep 1, 2026
11 checks passed
@andrzejfudro
andrzejfudro deleted the fix/health-schema-unavailable-fallback branch September 1, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants