Skip to content

feat(reconciler): append tab=profiles to MLRun Diagon console URLs - #791

Merged
VLukiantsev merged 2 commits into
mainfrom
feat/reconciler-mlrun-profiles-tab
Sep 7, 2026
Merged

VLukiantsev merged 2 commits into
mainfrom
feat/reconciler-mlrun-profiles-tab

Conversation

@VLukiantsev

Copy link
Copy Markdown
Collaborator

Summary

Updates the JobSet reconciler's deterministic Cloud Console URL generator to append &tab=profiles to generated Google Cloud Console AIML / Diagon run URLs, ensuring operators and users navigating from the experiment view are redirected directly to the Profiles tab upon clicking the "Run Profile" action button.

Key Changes

  • cmd/reconciler/jobset/reconciler.go:
    • Updated constructDiagnosticsConsoleURL to append &tab=profiles to the formatted Cloud Console AIML run URL:
      https://console.cloud.google.com/kubernetes/aiml/run/<location>/<mlRunID>?project=<project>&tab=profiles
  • cmd/reconciler/jobset/reconciler_test.go:
    • Added table-driven unit test TestConstructDiagnosticsConsoleURL verifying standard URL generation and empty argument handling.
    • Added table-driven unit test TestMLRunURL covering nil, missing, empty, and populated API response payloads.

Assumptions

  • None — requirements were fully specified. Relies on deterministic backend URL generation (constructDiagnosticsConsoleURL) to target the Profiles tab directly.

Verification & Testing

Automated Tests

  • Bazel Test Execution: bazel test //cmd/reconciler/... (All 7 targets passed cleanly, 100% pass rate).
    • //cmd/reconciler/jobset:jobset_test
    • //cmd/reconciler:reconciler_test
    • //cmd/reconciler/clusterqueue:clusterqueue_test
    • //cmd/reconciler/hypercomputeclient:hypercomputeclient_test
    • //cmd/reconciler/kueue_sync:kueue_sync_test
    • //cmd/reconciler/shared:shared_test
    • //cmd/reconciler/workload:workload_test
  • Pre-Commit Hooks: Passed all pre-commit linters:
    • Bazel Formatter & Linter (buildifier)
    • Go Formatter (gofmt)
    • Golang Linter (golangci-lint)
    • Go test determinism & state leakage check (266 files checked)
    • License header check (addlicense)
  • Diff Sizing Check: tools/analyze_diff_size.py reported:
    • Prod code lines: 2
    • Test code lines: 94
    • Total code lines: 96 (well within limits)

TAG=agy
CONV=18ec6201-6e57-42c2-8346-1a62d59c3638

- Update constructDiagnosticsConsoleURL to include &tab=profiles in the Google Cloud Console AIML run URL
- Add ensureProfilesTab helper to append &tab=profiles to MLRun URLs from API responses when missing
- Add comprehensive table-driven unit tests for constructDiagnosticsConsoleURL, ensureProfilesTab, and mlRunURL

TAG=agy
CONV=18ec6201-6e57-42c2-8346-1a62d59c3638
…L generation

- Remove ensureProfilesTab to rely solely on deterministic backend URL generation
- Update unit tests in reconciler_test.go

TAG=agy
CONV=18ec6201-6e57-42c2-8346-1a62d59c3638

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the constructDiagnosticsConsoleURL function to append &tab=profiles to the generated Google Cloud Console URL, preselecting the profiles tab. It also adds comprehensive unit tests to verify this URL construction and fallback behavior. I have no feedback to provide as the changes are well-implemented and covered by tests.

@VLukiantsev
VLukiantsev marked this pull request as ready for review September 7, 2026 08:46
@github-actions
github-actions Bot requested a review from janzak-dev September 7, 2026 08:46
@VLukiantsev
VLukiantsev added this pull request to the merge queue Sep 7, 2026
Merged via the queue into main with commit efb9172 Sep 7, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants