Repository navigation
feat(reconciler): append tab=profiles to MLRun Diagon console URLs - #791
Merged
Merged
Conversation
- Update constructDiagnosticsConsoleURL to include &tab=profiles in the Google Cloud Console AIML run URL - Add ensureProfilesTab helper to append &tab=profiles to MLRun URLs from API responses when missing - Add comprehensive table-driven unit tests for constructDiagnosticsConsoleURL, ensureProfilesTab, and mlRunURL TAG=agy CONV=18ec6201-6e57-42c2-8346-1a62d59c3638
…L generation - Remove ensureProfilesTab to rely solely on deterministic backend URL generation - Update unit tests in reconciler_test.go TAG=agy CONV=18ec6201-6e57-42c2-8346-1a62d59c3638
There was a problem hiding this comment.
Code Review
This pull request updates the constructDiagnosticsConsoleURL function to append &tab=profiles to the generated Google Cloud Console URL, preselecting the profiles tab. It also adds comprehensive unit tests to verify this URL construction and fallback behavior. I have no feedback to provide as the changes are well-implemented and covered by tests.
VLukiantsev
marked this pull request as ready for review
September 7, 2026 08:46
VLukiantsev
enabled auto-merge
September 7, 2026 08:46
janzak-dev
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the JobSet reconciler's deterministic Cloud Console URL generator to append
&tab=profilesto generated Google Cloud Console AIML / Diagon run URLs, ensuring operators and users navigating from the experiment view are redirected directly to theProfilestab upon clicking the "Run Profile" action button.Key Changes
cmd/reconciler/jobset/reconciler.go:constructDiagnosticsConsoleURLto append&tab=profilesto the formatted Cloud Console AIML run URL:https://console.cloud.google.com/kubernetes/aiml/run/<location>/<mlRunID>?project=<project>&tab=profilescmd/reconciler/jobset/reconciler_test.go:TestConstructDiagnosticsConsoleURLverifying standard URL generation and empty argument handling.TestMLRunURLcovering nil, missing, empty, and populated API response payloads.Assumptions
constructDiagnosticsConsoleURL) to target theProfilestab directly.Verification & Testing
Automated Tests
bazel test //cmd/reconciler/...(All 7 targets passed cleanly, 100% pass rate).//cmd/reconciler/jobset:jobset_test//cmd/reconciler:reconciler_test//cmd/reconciler/clusterqueue:clusterqueue_test//cmd/reconciler/hypercomputeclient:hypercomputeclient_test//cmd/reconciler/kueue_sync:kueue_sync_test//cmd/reconciler/shared:shared_test//cmd/reconciler/workload:workload_testbuildifier)gofmt)golangci-lint)addlicense)tools/analyze_diff_size.pyreported:TAG=agy
CONV=18ec6201-6e57-42c2-8346-1a62d59c3638