Repository navigation
feat(examples): add requirements.txt to all example workloads - #880
Merged
Merged
Conversation
Add standalone requirements.txt dependency manifests across all example workload directories to enable isolated and hermetic environment setup during test execution and multi-example runners. TAG=agy CONV=2889d5f4-f25d-4694-93f6-70447e012e6b
There was a problem hiding this comment.
Code Review
This pull request introduces requirements.txt files for various example workloads in the repository. The review feedback highlights that several of these files (specifically for pathways_job, per_job_node_selector, and xdash_dashboard) contain outdated dependency versions compared to other examples, and some are missing the protobuf dependency entirely. It is recommended to align these dependency versions across all examples to ensure consistency and prevent potential runtime issues.
…eview TAG=agy CONV=606f1e41-6785-4137-b85b-cd0f56237339
…ADMEs TAG=agy CONV=606f1e41-6785-4137-b85b-cd0f56237339
…e READMEs TAG=agy CONV=606f1e41-6785-4137-b85b-cd0f56237339
pachopepe
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stack Navigation
feat(examples): add requirements.txt to all example workloads👈feat(ci): add parallel trigger-all-examples runner and fix launch scriptsfeat(tools): add common verification framework and demo workload verify CLIfeat(ci,tools): add dedicated verification CLIs and e2e nightly test suite🏛️ Role in PR Stack Architecture
This PR serves as Layer 1 (Dependency Foundation & Packaging) within the 4-part multi-example execution and validation stack.
xmc-nightly.requirements.txtmanifests across all 12 example workloads and documents their usage inREADME.mdfiles. This allows subsequent layers (the parallel CI runner in Layer 2 and test validator environments in Layers 3 & 4) to deterministically provision isolated client virtual environments.Summary
Introduces standalone
requirements.txtdependency manifests and setup documentation across all example workloads inexamples/.Motivation & Context
Each example workload directory requires explicit Python dependencies for local execution, CI matrix triggers, and isolated hermetic environments. By providing explicit manifests, we eliminate implicit environment assumptions and ensure deterministic CI builds.
Key Changes
requirements.txtmanifests and documentation updates across all example workloads:examples/chart_artifact_job/examples/clickhouse_metrics_job/examples/demo_workload/examples/init_container_job/examples/managed_xprof_artifact_job/examples/metrics_dashboard_job/examples/metrics_job/examples/multipod_job/examples/pathways_job/examples/per_job_node_selector/examples/sidecar/examples/xdash_dashboard/Assumptions
None — requirements were fully specified.
Verification & Testing
./.githooks/pre-commit checkRelated Issues / Bugs
N/A
TAG=agy
CONV=606f1e41-6785-4137-b85b-cd0f56237339