Repository navigation
feat(ci): enable dashboard service deployment in nightly build and deploy-gke workflow - #893
Merged
Merged
Conversation
…ploy-gke workflow - Add dashboard_service_deployment_enabled input to .github/workflows/deploy-gke.yml (workflow_call and workflow_dispatch) and pass to generated deployment configuration YAML. - Enable dashboard_service_deployment_enabled: true in .github/workflows/nightly-build.yml for GKE nightly deployment. TAG=agy CONV=606f1e41-6785-4137-b85b-cd0f56237339
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
andrzejfudro
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables
dashboard_service_deployment_enabledin the nightly GKE deployment pipeline so that the XMC Dashboard Service is actively deployed and reachable on the nightly environment.Key Changes
.github/workflows/deploy-gke.yml:dashboard_service_deployment_enabledinput to bothworkflow_callandworkflow_dispatchtriggers (boolean, default:true).DASHBOARD_SERVICE_ENABLEDinto theGenerate Deployment Configurationstep environment and writedashboard_service_deployment_enabled: ${DASHBOARD_SERVICE_ENABLED}intodeploy/ctk_v2/xmanager-cloud-deployment.yaml..github/workflows/nightly-build.yml:dashboard_service_deployment_enabled: trueto thedeploy-nightlyjob call inputs.Verification
./.githooks/pre-commitchecks passed 100%.TAG=agy
CONV=606f1e41-6785-4137-b85b-cd0f56237339