Repository navigation
feat(ci): add unified nightly examples e2e pipeline workflow - #909
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request enhances the GitHub Actions results aggregation script to support both trigger-only and E2E test suite results, dynamically formatting the Markdown summary table columns and allowing custom titles. It also updates the CLI execution to exit with a non-zero code if any workload fails, and adds comprehensive unit tests for these new features. Feedback on the changes highlights a potential runtime crash and invalid map keys in aggregateResults due to missing null/undefined checks on the results array, along with redundant status check logic. A code suggestion was provided to filter the input array and safely simplify these checks.
janzak-dev
force-pushed
the
feat/nightly-examples-pipeline-base
branch
from
September 17, 2026 12:07
54aa94b to
3712468
Compare
janzak-dev
force-pushed
the
feat/nightly-examples-pipeline-base
branch
from
September 17, 2026 12:11
3712468 to
969c9e4
Compare
janzak-dev
force-pushed
the
feat/nightly-examples-pipeline-base
branch
from
September 17, 2026 12:51
969c9e4 to
bb53217
Compare
janzak-dev
force-pushed
the
feat/nightly-examples-pipeline-base
branch
from
September 17, 2026 13:03
de15808 to
d589673
Compare
janzak-dev
force-pushed
the
feat/nightly-examples-pipeline-base
branch
from
September 17, 2026 13:09
d589673 to
638eb86
Compare
TAG=agy CONV=606f1e41-6785-4137-b85b-cd0f56237339
…d in aggregate-example-results Comment link: #909 (comment)
janzak-dev
force-pushed
the
feat/nightly-examples-pipeline-base
branch
from
September 17, 2026 13:28
638eb86 to
ac0f2e5
Compare
janzak-dev
temporarily deployed
to
xmc-nightly
September 17, 2026 13:31 — with
GitHub Actions
Inactive
janzak-dev
temporarily deployed
to
xmc-nightly
September 17, 2026 13:31 — with
GitHub Actions
Inactive
janzak-dev
temporarily deployed
to
xmc-nightly
September 17, 2026 13:32 — with
GitHub Actions
Inactive
pachopepe
reviewed
Sep 17, 2026
pachopepe
previously approved these changes
Sep 17, 2026
pachopepe
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stack Navigation
feat(tools): make simple_job verification exhaustive with full protobuf resource and priority assertionsfeat(ci): add unified nightly examples e2e pipeline workflow👈feat(ci,tools): expand nightly examples suite to all 12 example workloads🏛️ Role in PR Stack Architecture
This PR serves as Layer 2 (Unified Nightly Examples Pipeline Architecture) within the nightly examples testing stack.
xmc-nightly..github/workflows/nightly-examples-e2e.ymlfollowing the PR refactor(ci): consolidate demo workload launch and verification into unified nightly workflow #895 single-action pattern with thesimple_jobbaseline matrix entry, alongside result aggregation scripts.🔄 Workflow Architecture & Distinction
This repository maintains two distinct nightly workflows serving complementary roles:
nightly-test-suite.yml(Single Simple Job Baseline Test)nightly-examples-e2e.yml(Extensible Examples Suite Pipeline Stub)launchverifyalert-on-failure).aggregate-example-results.js.simple_jobas the initial baseline, ready to be expanded to all 12 example workloads in upstack PR #910.Summary
Introduces the unified nightly examples E2E workflow pipeline (
.github/workflows/nightly-examples-e2e.yml) and Markdown table aggregation scripts (.github/scripts/aggregate-example-results.js), running againstxmc-nightlyon GKE with asimple_jobbaseline matrix entry.Motivation & Context
Key Changes
.github/workflows/nightly-examples-e2e.yml):0 3 * * *) andworkflow_dispatchpipeline for nightly examples testing.simple_jobbaseline matrix entry running in a Python virtual environment..github/scripts/):aggregate-example-results.js: Aggregates per-workload execution JSON results into a Markdown summary table.aggregate-example-results.test.js: Hermetic Node.js unit tests (11 tests).Assumptions
None — requirements were fully specified.
Verification & Testing
bazel test //tools/nightly_tests:all(2/2 test targets passed)node --test .github/scripts/aggregate-example-results.test.js(11/11 tests passing)./.githooks/pre-commit check(100% clean)nightly-examples-e2e.yml: Run #35227569927 (Status: ✅ Success —simple_jobmatrix execution & aggregation verified)nightly-test-suite.yml: Run #35227574323 (Status: ✅ Success — existing demo workload baseline verified)TAG=agy
CONV=606f1e41-6785-4137-b85b-cd0f56237339