Repository navigation
feat(ui): align page layout and add expandable sidenav rail (72px ↔ 240px) - #953
Merged
Merged
Conversation
Align the page-container background (#ffffff) and fixed 200px sidenav drawer (#f8f9fa background, #e8eaed border, and #e8f0fe/#1a73e8 active route pill) with the prototype while keeping the drawer non-expandable. TAG=agy CONV=10ea5f21-5600-4e9d-91a0-f605c676b5bd
There was a problem hiding this comment.
Code Review
This pull request introduces active link styling to the sidenav navigation items and updates layout colors and spacing. The feedback highlights the need to maintain themeability, specifically dark mode support, by replacing hardcoded hex colors with Material Design CSS custom properties. Additionally, it suggests removing redundant CSS declarations in the menu item container that are already inherited from parent elements.
Comment link: #953 (comment) TAG=agy CONV=10ea5f21-5600-4e9d-91a0-f605c676b5bd
AntonTyb
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns Area #2 (Page Layout & Expandable Sidenav Navigation Rail) from the Prototype Style Alignment Audit:
isExpandedstate +toggleExpand()incmd/ui/app/app.ts):72pxicon rail):56px × 56pxcircular pill items (border-radius: 28px), centered icons,40pxdivider, and achevron_rightExpand button at the bottom.240pxdrawer): Smoothly transitions (0.2s cubic-bezier(0.2, 0, 0, 1)) to240pxwidth with216px × 56pxrounded pill items (border-radius: 28px,padding: 0 20px,gap: 16px), visible text labels (.nav-label), full-width divider, and achevron_leftCollapse button.var(--mat-sys-primary-container, #d3e3fd)fill,var(--mat-sys-on-primary-container, #041e49)text & icon,600weight).(Part 2 of 8 in the scoped UI Style Alignment series corresponding to Area #2 of the Style Inconsistency Table.)
Visual Comparison (Before vs. After)
Component-Level Diff (Area #2: Expandable Sidenav
72pxCollapsed ↔240pxExpanded)📸 Full-Page Context Screenshot (Production vs. Prototype)
Motivation & Context
Brings Area #2 of
cmd/ui/(app.ts,app.ng.html,app.scss) into visual alignment with the Google Cloud / Material 3 prototype specification, including the expandable/collapsible left navigation rail.Key Changes
cmd/ui/app/app.ts: Addreadonly isExpanded = signal(false);andtoggleExpand().cmd/ui/app/app.ng.html: Bind[class.nav-expanded],[class.nav-closed], and[class.expanded]="isExpanded()", render.nav-labelwhen expanded, and add.nav-divider+.nav-expand-btn(chevron_right/chevron_left+Collapse).cmd/ui/app/app.scss: Style the72pxcollapsed icon rail (56px × 56pxcircular pills) and240pxexpanded drawer (216px × 56pxrounded pills) with Material 3 CSS custom properties and prototype hex fallbacks.cmd/ui/screenshot_tests/test_utils.ts: Keep deterministic200pxcontent margin inBASE_SCREENSHOT_STYLESso existing inner-page screenshot baselines remain unaffected.Verification & Testing
npm run lint(ESLint & Angular template lint passed cleanly)npm run build(Angular production bundle compiled cleanly)npm test -- --watch=false --browsers=ChromeHeadlessNoSandbox(616 of 616 SUCCESS)npx playwright test(Playwright visual regression tests passed)Related Issues / Bugs
N/A
TAG=agy
CONV=10ea5f21-5600-4e9d-91a0-f605c676b5bd