Repository navigation
fix(pausescheduling): mark paused work units and show them in the UI - #984
Merged
Merged
Conversation
The pause handler sent "status.state_update_time" in the WorkUnitExecution update mask. Storage rejects it as not updateable, so buffering a task during a scheduling pause failed with InvalidArgument and the task went to the DLQ while the work unit stayed INITIALIZING. "status.state" already persists StateUpdateTime (and requires it to be set), so the mask now contains only "status.state". The test asserts the timestamp is still populated. TAG=agy CONV=aca941d1-8c29-4820-96a9-0200c1071207
Work units in SCHEDULING_PAUSED fell through to the "Unknown" status chip. Map the state to a "Scheduling Paused" chip with a dedicated orange style, and add an orange segment for it in the experiment work units status bar so admin-paused work is distinct from initializing and scheduling. TAG=agy CONV=aca941d1-8c29-4820-96a9-0200c1071207
There was a problem hiding this comment.
Code Review
This pull request introduces support for the "SCHEDULING_PAUSED" status across both the backend and frontend. In the backend, the update mask for work unit executions is simplified to only require "status.state" (which implicitly persists the state update time), and the tests are updated to verify this behavior. In the frontend, the new "SCHEDULING_PAUSED" status is integrated into the status chip, status bar, and work units table components, along with corresponding orange styling and unit tests. There are no review comments, so I have no feedback to provide.
andrzejfudro
marked this pull request as ready for review
September 25, 2026 07:42
andrzejfudro
enabled auto-merge
September 25, 2026 07:42
pachopepe
previously approved these changes
Sep 25, 2026
Addresses review feedback on #984: map SCHEDULING_PAUSED to StatusOption.SCHEDULING_PAUSED in Header.getStatusOption so that the work unit header chip does not display as Unknown. #984 (comment) TAG=agy
pachopepe
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix updating
SCHEDULING_PAUSEDstate and show the state in the UI.Key Changes
status.state.status.state_update_timeis not an updateable path in storage, so every pause-buffered task failed withInvalidArgumentand went to the DLQ while the work unit stayedINITIALIZING.status.statealready persistsStateUpdateTimeand requires it to be set.SCHEDULING_PAUSEDin the work units table.INITIALIZING.StateUpdateTime; work units table test covers the paused label.Verification
bazel test //cmd/actuator/pausescheduling:pausescheduling_test(Passed)bazel build //cmd/ui:ui_image_tarball(Passed)SCHEDULING_PAUSEDand render the new chip.node_modulescould not be installed).Preview
TAG=agy
CONV=aca941d1-8c29-4820-96a9-0200c1071207