Repository navigation
fix(dev-env): push rod image when rod_deployment_enabled is unset - #994
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request changes the default value of rod_deployment_enabled from False to True in the configuration loader and updates the corresponding unit tests. The review feedback highlights a potential bug where an explicit null or empty value in the YAML configuration parses as None, which incorrectly evaluates to False and disables the deployment. The reviewer suggested a safer fallback to handle None values correctly and recommended adding a test case to verify this behavior.
The ROD image push and upgrade restart were gated on rod_deployment_enabled, which defaults to false in the tooling but true in the blueprint, so ROD was deployed without its image. TAG=agy CONV=0d838051-28db-4cc1-ae82-369e3cad52f1
andrzejfudro
force-pushed
the
fix/dev-env-rod-image-default
branch
from
September 25, 2026 12:40
43bf92a to
c092ac8
Compare
andrzejfudro
marked this pull request as ready for review
September 25, 2026 12:42
janzak-dev
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gke-deployonly pushed the ROD image whenrod_deployment_enabledwas true, and the tooling defaulted that flag to false while the blueprint defaults it to true. ROD got deployed without its image, the pod sat inImagePullBackOff, and thexmc_appstep failed on a Helm timeout.Key Changes
rod_data_provider, same as the other optional services.rod-data-provider; missing deployments are already skipped.rod_deployment_enabledfield fromDeploymentConfig.Verification
bazel test //tools/common:tool_utils_test //tools/dev_env:deploy_dev_env_test //tools/dev_env:upgrade_dev_env_test //tools/dev_env:dev_env_test(Passed)TAG=agy
CONV=0d838051-28db-4cc1-ae82-369e3cad52f1