Skip to content

fix(dev-env): push rod image when rod_deployment_enabled is unset - #994

Merged
andrzejfudro merged 1 commit into
mainfrom
fix/dev-env-rod-image-default
Sep 25, 2026
Merged

andrzejfudro merged 1 commit into
mainfrom
fix/dev-env-rod-image-default

Conversation

@andrzejfudro

@andrzejfudro andrzejfudro commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

gke-deploy only pushed the ROD image when rod_deployment_enabled was true, and the tooling defaulted that flag to false while the blueprint defaults it to true. ROD got deployed without its image, the pod sat in ImagePullBackOff, and the xmc_app step failed on a Helm timeout.

Key Changes

  • Image push: always push rod_data_provider, same as the other optional services.
  • Upgrade restart: always include rod-data-provider; missing deployments are already skipped.
  • Config: dropped the now-unused rod_deployment_enabled field from DeploymentConfig.
  • Tests: updated image/restart counts and removed the ROD-enabled variants.

Verification

  • bazel test //tools/common:tool_utils_test //tools/dev_env:deploy_dev_env_test //tools/dev_env:upgrade_dev_env_test //tools/dev_env:dev_env_test (Passed)
  • Fresh dev deployment: ROD pod came up once its image was pushed.

TAG=agy
CONV=0d838051-28db-4cc1-ae82-369e3cad52f1

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request changes the default value of rod_deployment_enabled from False to True in the configuration loader and updates the corresponding unit tests. The review feedback highlights a potential bug where an explicit null or empty value in the YAML configuration parses as None, which incorrectly evaluates to False and disables the deployment. The reviewer suggested a safer fallback to handle None values correctly and recommended adding a test case to verify this behavior.

Comment thread tools/common/tool_utils.py Resolved
Comment thread tools/common/tool_utils_test.py Resolved
The ROD image push and upgrade restart were gated on rod_deployment_enabled,
which defaults to false in the tooling but true in the blueprint, so ROD was
deployed without its image.

TAG=agy
CONV=0d838051-28db-4cc1-ae82-369e3cad52f1
@andrzejfudro
andrzejfudro force-pushed the fix/dev-env-rod-image-default branch from 43bf92a to c092ac8 Compare September 25, 2026 12:40
@andrzejfudro
andrzejfudro marked this pull request as ready for review September 25, 2026 12:42
Comment thread tools/dev_env/deploy_dev_env_test.py Resolved
@andrzejfudro
andrzejfudro added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 5bc5692 Sep 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants