Repository navigation
Make login session lifetime configurable - #997
Merged
Merged
Conversation
Add `SESSION_TTL` and Helm's `auth.sessionTtl` so deployments can choose longer login sessions. Keep the default at 1h, validate the duration at startup, and use the same expiry for the token and cookie.
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable login session lifetime (SESSION_TTL) across the Helm chart and Go backend, allowing the absolute lifetime of session tokens and browser cookies to be customized. It includes validation logic, updated unit tests, and a new Helm integration test. The review feedback recommends additionally setting the MaxAge attribute on the session cookie to prevent potential issues with client clock drift.
pachopepe
previously approved these changes
Sep 28, 2026
Set the session cookie’s `MaxAge` from the configured lifetime in whole seconds. Verify it in the serialized cookie for every tested lifetime. #997 (comment)
Collaborator
Author
|
@pachopepe thanks for the quick review/approval! I pushed a fixup for the |
hartikainen
enabled auto-merge
September 28, 2026 13:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
SESSION_TTLand Helm'sauth.sessionTtlso deployments can choose longer login sessions. Keep the default at 1h, validate the duration at startup, and use the same expiry for the token and cookie.Closes #996.
(Coded with help from Astra.)