Cronet extension: Support cookie storage #5975

Activity

1. stufan

   added

   needs triage

   question

   on May 30, 2019
2. google

   deleted a comment from google-oss-bot on May 30, 2019
3. ojw28 commented on May 30, 2019

   

   ojw28

   on May 30, 2019

   Last edited by ojw28

   Contributor

   More actions

   Cronet doesn't store cookies, as per this issue. I think the best approach here would be to:

   1. Define a simple CookieStore interface in the Cronet extension, and allow an implementation to be injected from app code.
   2. App code would be responsible for injecting an implementation. We'd design CookieStore to trivially map onto OkHttp's CookieJar or the platform CookieHandler, so developers can easily implement CookieStore as a wrapper around one of these APIs. It would probably just define:

   put(Uri uri, Map<String, List<String>> responseHeaders);
   Map<String, List<String>> get(Uri);
   

   Comment 4 on the issue above has a few changed references that show how easy the mapping is, and how the interface would be used from inside CronetDataSource.

   We wont be treating this as high priority, but would accept a pull request if you're able to help ;).
4. ojw28

   added

   enhancement

   low priority

   and removed

   needs triage

   question

   on May 30, 2019
5. ojw28

   self-assigned this

   on May 30, 2019
6. ojw28

   changed the title [-]Cronet extension doesn't set cookies[/-] [+]Cronet extension: Support cookie storage[/+] on May 30, 2019
7. drayan85 commented on May 5, 2021

   

   drayan85

   on May 5, 2021

   More actions

   I have used this additional method to add the Cookie Header every time for the existing httpDataSourceFactory manually and works for me.

   private static HttpDataSource.@MonotonicNonNull Factory httpDataSourceFactory;

     public static synchronized HttpDataSource.Factory getHttpDataSourceFactory(final Context context) {
       if (httpDataSourceFactory == null) {
         CronetEngineWrapper cronetEngineWrapper = new CronetEngineWrapper(context.getApplicationContext(),
                 USER_AGENT, /* preferGMSCoreCronet= */ false);
         httpDataSourceFactory = new CronetDataSource.Factory(cronetEngineWrapper, Executors.newSingleThreadExecutor())
                 .setHandleSetCookieRequests(true).setAllowCrossProtocolRedirects(true);
       }
       return httpDataSourceFactory;
     }
   

     public static void addCronetCookies(final Context context, final HashMap<String, String> cookies) {
       if (httpDataSourceFactory == null) {
         getHttpDataSourceFactory(context);
       }
       StringBuilder builder = new StringBuilder();
       for (String key : cookies.keySet()) {
         if (builder.length() > 0) {
           builder.append(";");
         }
         builder.append(key).append("=").append(cookies.get(key));
       }
       HashMap<String, String> headerCookie = new HashMap<>();
       headerCookie.put("Cookie", builder.toString());
   
       httpDataSourceFactory.setDefaultRequestProperties(headerCookie);
     }
   
8. ojw28

   assigned

   icbaker

   and unassigned

   ojw28

   on Jul 5, 2022
9. copybara-service

   added a commit that references this issue on May 28, 2025

   Add full cookie handling to CronetDataSource

   ...

   b179aed
10. guoen21

    added a commit that references this issue on Mar 30, 2026

    Feat/migrate media3 1.8 (#43)

    ...

    2573f65