Deduplicate GNM edge list#46
Open
RobbieRao wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot rescan |
RobbieRao
marked this pull request as ready for review
July 23, 2026 17:16
RobbieRao
force-pushed
the
agent/fix-edge-list-deduplication
branch
from
July 23, 2026 17:18
79c8aab to
e1a994f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GNM.edge_listRoot cause
edge_listcanonicalized each edge as(min(v1, v2), max(v1, v2)), but computed uniqueness keys from the original directed endpoints. Shared quad edges commonly appear with opposite winding, so(u, v)and(v, u)received different keys even though they represented the same undirected edge. Both copies were then expanded in both directions.Impact
For GNM Head v3,
edge_listshrinks from 141,296 rows to 70,946 rows while preserving the same adjacency. All 70,946 returned directed edges are unique.Testing
python gnm/shape/gnm_numpy_test.py— 82 passed, 2 skippedpython gnm/shape/run_all_tests.py— 278 passed, 2 skippedpylint gnm/shape/gnm_xnp.py gnm/shape/gnm_numpy_test.py