Fix catastrophic cancellation in f32 and f16 vcos microkernels near x = pi + 2*pi*n by replacing floating-point theta offsets with integer quadrant range reduction and symmetry/sign folding, ensuring exact numerical equivalence with YNNPACK.#10810
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
copybara-service
Bot
force-pushed
the
test_951618805
branch
from
July 21, 2026 20:04
30883ca to
9024ead
Compare
Contributor
|
The rvv cmake and bzl files would need to be updated. |
copybara-service
Bot
force-pushed
the
test_951618805
branch
from
July 22, 2026 23:02
9024ead to
8b497d1
Compare
copybara-service
Bot
force-pushed
the
test_951618805
branch
2 times, most recently
from
July 23, 2026 18:03
3345a6d to
2f9bf21
Compare
… = pi + 2*pi*n by replacing floating-point theta offsets with integer quadrant range reduction and symmetry/sign folding, ensuring exact numerical equivalence with YNNPACK. PiperOrigin-RevId: 951618805
copybara-service
Bot
force-pushed
the
test_951618805
branch
from
July 23, 2026 19:11
2f9bf21 to
809f05a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix catastrophic cancellation in f32 and f16 vcos microkernels near x = pi + 2pin by replacing floating-point theta offsets with integer quadrant range reduction and symmetry/sign folding, ensuring exact numerical equivalence with YNNPACK.