fix(sequentialagent): correct New godoc placement and copy-pasted error string (#1151) - #1531
Merged
Merged
Conversation
…or string (#1151) The "New creates a SequentialAgent" doc comment was attached to the seqAgent type after the live-mode changes inserted the type between the comment and func New, leaving New with only an orphaned fragment. Reunite the full doc comment with New and give seqAgent its own comment. Also fix the custom-Run guard error, which reported "LoopAgent" instead of "SequentialAgent" (copy-paste from loopagent; parallelagent names itself correctly). Co-authored-by: David Mora <david.mora@huli.io> Co-authored-by: wolo <wolo@google.com> Backported by hand: the automated replay could not apply, because v1 had the same two defects in a different arrangement -- the New godoc was attached to seqAgent with a dangling fragment above New -- so the patch context did not match. The resulting file is identical to main after the module-path rewrite, apart from the pre-existing agent.Context/agent.ToolContext difference between the branches. (cherry picked from commit 0da17d5)
wojtas000
self-requested a review
September 7, 2026 17:34
wojtas000
approved these changes
Sep 7, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #1151 from
maintov1.Done by hand: the automated replay conflicts.
v1carries the same two defects asmaindid, in a different arrangement — theNewgodoc is attached toseqAgentandNewis left with an orphaned fragment above it — so the patch context does not match andgit apply, including--3way, rejects hunk 2.The result is byte-identical to
mainafter the module-path rewrite, apart from the pre-existingagent.Context/agent.ToolContextdifference between the branches, which is unrelated to this change.Carries the
(cherry picked from commit …)trailer, so the backport tooling recognises #1151 as done and drops it from the queue.go buildandgo test ./agent/workflowagents/sequentialagent/pass.