Skip to content

Align vertexai session service via ADK REST API with other impl - #1571

Open
kdroste-google wants to merge 1 commit into
google:mainfrom
kdroste-google:fixRestSessionService
Open

kdroste-google wants to merge 1 commit into
google:mainfrom
kdroste-google:fixRestSessionService

Conversation

@kdroste-google

Copy link
Copy Markdown
Contributor

Problem:

The following route

		Route{
			Name:        "GetSession",
			Methods:     []string{http.MethodGet},
			Pattern:     "/apps/{app_name}/users/{user_id}/sessions/{session_id}",
			HandlerFunc: r.sessionController.GetSessionHandler,
		},

doesn't behave the same for different implementations.

For VertexAI Session Service the result of getting the session belonging to another user results in HTTP 500. For other implementations: HTTP 404.

Solution:
Aligning the vertexai implementation.

@wolo-lab wolo-lab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants