Add a stub setup function for !unix && !windows builds#46
Merged
Conversation
Requesting system logging will then fail at runtime.
adjackura
approved these changes
Jul 5, 2023
Piyushhbhutoria
added a commit
to Piyushhbhutoria/logger
that referenced
this pull request
Sep 21, 2024
Add a stub setup function for !unix && !windows builds (google#46)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting system logging will then fail at runtime.
It's possible that we eventually want to be more lenient: I don't know how this is called in practise today. Callers would need to ignore the error or pass systemLog=false. But at least it allows the binary to build.
Fixes #45