Skip to content

Build docker image from current source - #75

Merged
robertswiecki merged 1 commit into
google:masterfrom
D0han:master
Apr 18, 2018
Merged

Build docker image from current source#75
robertswiecki merged 1 commit into
google:masterfrom
D0han:master

Conversation

@D0han

@D0han D0han commented Apr 12, 2018

Copy link
Copy Markdown
Contributor

Dockerfile adapted for building images with relevant revision instead of HEAD

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@D0han

D0han commented Apr 12, 2018

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@robertswiecki

robertswiecki commented Apr 12, 2018

Copy link
Copy Markdown
Collaborator

Hi @disconnect3d - WDYT?

@disconnect3d disconnect3d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@robertswiecki
robertswiecki merged commit cfa3a64 into google:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants