Skip to content

refactor(tools): move annotations into ConfigBase - #4064

Open
RaulS0sa wants to merge 11 commits into
googleapis:mainfrom
RaulS0sa:refactor/move-annotations-into-config-base
Open

refactor(tools): move annotations into ConfigBase#4064
RaulS0sa wants to merge 11 commits into
googleapis:mainfrom
RaulS0sa:refactor/move-annotations-into-config-base

Conversation

@RaulS0sa

@RaulS0sa RaulS0sa commented Sep 16, 2026

Copy link
Copy Markdown

Description

Should include a concise description of the changes (bug or feature), it's
impact, along with a summary of the solution

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure you have manually reviewed the entire diff before requesting a
    review
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

@RaulS0sa
RaulS0sa requested review from a team as code owners September 16, 2026 22:55
@google-cla

google-cla Bot commented Sep 16, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 16, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the tool configuration structure by moving the Annotations field from individual tool Config structs and MockToolConfig into the shared tools.ConfigBase struct, which they all embed. This eliminates redundant field declarations across dozens of database tools (including AlloyDB, BigQuery, BigTable, Cloud SQL, Firestore, Looker, MongoDB, Postgres, etc.) and updates the corresponding tests and developer documentation (DEVELOPER.md and GEMINI.md) to reflect this change. I have no feedback to provide as there are no review comments to evaluate.

@RaulS0sa

RaulS0sa commented Sep 17, 2026

Copy link
Copy Markdown
Author

/gcbrun

@Yuan325

Yuan325 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

/gbrun

@RaulS0sa

RaulS0sa commented Sep 18, 2026

Copy link
Copy Markdown
Author

/gbrun

@RaulS0sa

RaulS0sa commented Sep 18, 2026

Copy link
Copy Markdown
Author

/gcbrun

1 similar comment
@Yuan325

Yuan325 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@RaulS0sa

RaulS0sa commented Sep 18, 2026

Copy link
Copy Markdown
Author

/gbrun

@Yuan325

Yuan325 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@RaulS0sa

RaulS0sa commented Sep 19, 2026

Copy link
Copy Markdown
Author

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@duwenxin99 duwenxin99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RaulS0sa @Yuan325 @duwenxin99