This repository was archived by the owner on Sep 9, 2020. It is now read-only.
fix(status): print verbose messages#1009
Merged
Merged
Conversation
jmank88
reviewed
Aug 14, 2017
| logger := ctx.Err | ||
| if !ctx.Verbose { | ||
| logger = log.New(ioutil.Discard, "", 0) | ||
| } |
Collaborator
There was a problem hiding this comment.
Can this either be combined with the preceding if ctx.Verbose block into an if/else, or can it be moved down closer to it's usage or in a narrower scope?
Collaborator
Author
There was a problem hiding this comment.
oh! yeah, this can be in else part of the preceding Verbose reference. Thanks :)
9a29e13 to
394b995
Compare
sdboyer
approved these changes
Aug 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Adds verbose messages to
status. This is required to provide some feedback when the operation takes too long.What should your reviewer look out for in this PR?
Verbose message. Maybe better wording?
Do you need help or clarification on anything?
Anything else that we can log here?
Which issue(s) does this PR fix?
Related to #1008