This repository was archived by the owner on Sep 9, 2020. It is now read-only.
status: adding counts to verbose output#1037
Merged
Merged
Conversation
Collaborator
Author
|
I like the idea of using this If others are on board, it could be added to some other existing output, like: Or: Edit: Dry run output ( Related #1038 |
carolynvs
reviewed
Aug 19, 2017
| for _, proj := range slp { | ||
| logger.Println(proj.Ident().ProjectRoot) | ||
| for i, proj := range slp { | ||
| logger.Printf("(%d/%d) %s\n", i+1, len(slp), proj.Ident().ProjectRoot) |
Collaborator
There was a problem hiding this comment.
Does go lift the len computation out of the loop?
Collaborator
There was a problem hiding this comment.
No, but there is not really any "computation" going on. Slice lengths are stored in the slice internal struct representation.
Collaborator
There was a problem hiding this comment.
Oh nice! 👍 Thanks for the explanation.
carolynvs
approved these changes
Aug 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Small tweak to verbose status output adding counts so that progress can be roughly monitored.
Before:
After:
Which issue(s) does this PR fix?
Follow up from #1009, related to #1008