Conversation
- Added `RegionIntersection` struct for computing the intersection of regions. - Provided comprehensive unit tests to verify functionality. - Updated `README.md` and `region.go` to reflect the addition of `RegionIntersection`.
jmr
requested changes
Jun 10, 2026
| @@ -0,0 +1,74 @@ | |||
| // Copyright 2006 Google Inc. All rights reserved. | |||
Collaborator
There was a problem hiding this comment.
Copyright 2006-2026 Google LLC. All rights reserved.
| _ Region = Cap{} | ||
| _ Region = Cell{} | ||
| _ Region = (*CellUnion)(nil) | ||
| _ Region = RegionIntersection{} |
Collaborator
There was a problem hiding this comment.
Move this to the end before RegionUntion.
|
|
||
| // RectBound returns a bounding latitude-longitude rectangle for this RegionIntersection. | ||
| func (ri RegionIntersection) RectBound() Rect { | ||
| ret := FullRect() |
Collaborator
There was a problem hiding this comment.
rect is more idiomatic. I updated RegionUnion to use rect.
Collaborator
|
@fmeurisse do you have some cycles to address the changes? Would love to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports S2RegionIntersection from the C++ S2 library to Go
s2/region.go — also adds _ Region = RegionUnion{}, which was previously missing from the compile-time interface assertions.