Skip to content

Conversation

@savioxavier
Copy link
Member

@savioxavier savioxavier commented Jan 28, 2022

Hello there,

This PR makes the UI for the Minima website responsive (sort of)

The following stuff were updated/fixed:

  • Update the following components to make them responsive and mobile-friendly:
    • Hero.vue
    • Navbar.vue
    • WhatsNew.vue
    • [...all].vue (404 page)
  • Update styles for 404 page ([...all.vue])

Screenshots:

image

image

image

Side note: This is a follow-up of PR #2

@vercel
Copy link

vercel bot commented Jan 28, 2022

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/gominima/settings/billing.

@apoorvcodes apoorvcodes marked this pull request as ready for review January 28, 2022 09:56
@savioxavier savioxavier marked this pull request as draft January 28, 2022 10:04
@savioxavier
Copy link
Member Author

Should be ready for deployment... except there is one tiny issue:

I couldn't figure out how to toggle the mobile navbar (See Navbar.vue of this PR)
(On line 57 of Navbar.vue):

<!-- Mobile menu -->
      <!-- FIX: Toggle element on mobile -->

If it's possible to fix it, please do @apoorvcodes. Until then, this PR will be marked as draft

@savioxavier
Copy link
Member Author

Or if you would like to fix this in another commit, you can mark this PR as ready for review and merge it to master. Your call.

@apoorvcodes
Copy link
Member

Let's merge it I'll pr later today to fix it

@apoorvcodes
Copy link
Member

@megatank58 review and merge

@savioxavier savioxavier marked this pull request as ready for review January 28, 2022 10:53
@megatank58 megatank58 closed this Jan 28, 2022
@megatank58 megatank58 reopened this Jan 28, 2022
@megatank58
Copy link
Contributor

oh woops

@megatank58 megatank58 merged commit b9d55fe into gominima:master Jan 28, 2022
@savioxavier savioxavier deleted the update-ui-responsive branch February 9, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants