fix(ci::dogfood): reduce compute complexity of dogfood task - #1077
Merged
Conversation
📝 WalkthroughWalkthroughThe ChangesSmoke-test build target
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
norrietaylor
approved these changes
Jul 29, 2026
norrietaylor
enabled auto-merge (squash)
July 29, 2026 20:11
twitchyliquid64
force-pushed
the
tom/check-sop
branch
from
July 29, 2026 20:12
326e695 to
0feed07
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 100: Obtain CODEOWNER approval from `@gominimal/minimalists` before merging
the change to the CI workflow, as required by the repository’s
.github/CODEOWNERS rule.
In @.minimal/minimal.toml:
- Around line 24-25: Update the smoke-test task in minimal.toml to build the mip
CLI package instead of only common, ensuring the dogfood step validates Minimal
CLI compilation; alternatively, add a separate task that explicitly builds mip
while preserving the existing common build.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 15fcf4ff-c33d-4cf0-89b1-32ebc7c420e6
📒 Files selected for processing (2)
.github/workflows/ci.yml.minimal/minimal.toml
| if: github.event_name != 'pull_request' || needs.changes.outputs.code == 'true' | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 | ||
| timeout-minutes: 25 |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the workflow line in question
if [ -f .github/workflows/ci.yml ]; then
sed -n '90,110p' .github/workflows/ci.yml
fi
# Find ownership rules that apply to workflows
if [ -f CODEOWNERS ]; then
echo "=== CODEOWNERS ==="
cat CODEOWNERS
fi
if [ -f .github/CODEOWNERS ]; then
echo "=== .github/CODEOWNERS ==="
cat .github/CODEOWNERS
fi
# Look for any repo guidance mentioning frozen workflows / CI ownership
rg -n "workflow|CODEOWNER|frozen|ci.yml" .github README.md . || trueRepository: gominimal/minimal
Length of output: 23382
Do not merge this workflow edit without CODEOWNER review. .github/CODEOWNERS assigns * to @gominimal/minimalists, so .github/workflows/ci.yml needs owner approval.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/ci.yml at line 100, Obtain CODEOWNER approval from
`@gominimal/minimalists` before merging the change to the CI workflow, as required
by the repository’s .github/CODEOWNERS rule.
Sources: Coding guidelines, Learnings
Comment on lines
+24
to
+25
| description = "Smoke-test that a task can build something" | ||
| exec = "cargo build -p common" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Keep the smoke test on the CLI package. cargo build -p common no longer exercises mip, so the dogfood step can pass even if the Minimal CLI stops compiling. Keep building mip here, or add a second task for it.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.minimal/minimal.toml around lines 24 - 25, Update the smoke-test task in
minimal.toml to build the mip CLI package instead of only common, ensuring the
dogfood step validates Minimal CLI compilation; alternatively, add a separate
task that explicitly builds mip while preserving the existing common build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Checklist
BREAKING CHANGE:footer present if this is a breaking changeNote
Fix dogfood CI timeout by switching
build-smoketask tocargo build -p commonUpdates minimal.toml to run
cargo build -p commoninstead ofcargo build -p mipin thebuild-smoketask, which fixes the CI timeout in the dogfood pipeline.Macroscope summarized 0feed07.
Summary by CodeRabbit
commoncomponent using its dedicated build command.