fix: correct shell-exit prompt copy that falsely implies a live session - #1018
Conversation
…sion The first option on the shell-exit prompt read "Detach, leaving the session running", but the prompt only appears after the shell process has already exited, so nothing is left running. A user could wrongly conclude they can reattach to a live shell. Change the option to "Exit, leaving the session filesystem in place and recoverable", which states what actually survives (the on-disk session state) and parallels the "Delete" option below it. The SHELL_EXIT_PROMPT constant asserted against in session.rs matches only the prompt header, not the option text, so no tests are affected.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
Fixes #1015
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABKkzwRQ
What
The
minimaldshell-exit prompt offeredDetach, leaving the session runningas its first option. That prompt is shown only after the session's shell
process has already exited (the
MainloopExitReason::ProcessExitedbranch insession_host.rs), so nothing is left running. A user reading it couldreasonably conclude their processes are still alive and that they can reattach
to a live shell — they cannot. What actually survives is the session's on-disk
state, which is what makes the choice meaningful against the
Deleteoptionbelow it.
Change
A single string literal at
crates/minimald/src/session_host.rs:504:Detach, leaving the session runningExit, leaving the session filesystem in place and recoverableThe new copy states what is preserved (the filesystem) and what that buys the
user (recoverability), drops the false "running" claim, and parallels the
Deleteoption, which is already phrased in terms of files. The optionordering and
Selection::At(0)/At(1)indices are unchanged, so thedetach/delete control flow below is untouched.
The
SHELL_EXIT_PROMPTconstant (session_host.rs:47) is asserted against insession.rs:1853andsession.rs:1923, but those.contains(...)checksmatch the prompt header, not the option text, so the change does not break
them — confirmed both by reading the assertions and by the green test run.
The Distillery precedent pass (project
minimal) surfaced only distinct priorwork (PR #431 terminal-reset-on-detach; PRs #375/#425/#462 session infra);
none bears on this user-facing copy fix.
Verification
All commands run from the workspace root against
target/Cargo.tomlwith--locked(CI parity). Every command exited 0.cargo fmt --all --check --manifest-path target/Cargo.toml— clean, no drift.cargo clippy --workspace --locked --manifest-path target/Cargo.toml -- -D warnings— exit 0, no warnings.cargo build --workspace --locked --manifest-path target/Cargo.toml— exit 0 (Finished dev profile in 4m 29s).cargo test --workspace --locked --manifest-path target/Cargo.toml— exit 0; all workspace tests and doctests passed (no name filter; theminimaldsession_host/sessionsuites are included).Note
Fix shell exit dialog label that falsely implied a live session was detaching
Updates the first option in the shell exit prompt in session_host.rs from 'Detach, leaving the session running' to 'Exit, leaving the session filesystem in place and recoverable'. Selection behavior is unchanged.
Macroscope summarized f819154.