fix(release): call min completions print in the release job - #1034
Conversation
#1009 split `min completions <shell>` into `completions print` and `completions install`; the release job still called the flat form, so `Generate completions` exited 2 on run 30425725370 and the release never reached GCS or the GitHub Release. Switch the three `min` lines to `completions print <shell>`, and name their outputs after the `min` binary (`min`, `_min`, `min.fish`) rather than the crate: the shim `min` prints registers the command `min`, so a shell only ever autoloads it from a file of that name — the `minimal`/`_minimal` files shipped in `completions.tar.gz` since the binary rename (#737) were dead on arrival. `mip` and `minimald` keep the flat verb; only the `min` CLI changed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
What broke
Release run 30425725370 failed in the
releasejob's Generate completions step:#1009 split
min completions <shell>intomin completions print <shell>andmin completions install. The release job still called the flat form, so the step exited 2 and everything after it — GCS archive upload, Create Release,stage-installer— never ran. Every build job succeeded; only the packaging step is broken.mipandminimaldkeep the flatcompletions <shell>verb, so their six lines are untouched.The fix
minlines becomecompletions print <shell>.min/_min/min.fish. The shimmin completions printemits registers the commandmin(complete … _clap_complete_min min,compdef _clap_dynamic_completer_min min,complete --command min), and every shell autoloads a completion file by the command name — so theminimal/_minimal/minimal.fishfiles shipped incompletions.tar.gzhave been dead on arrival since the binary rename in #737. Flagging this as the one change beyond the literal build break; nothing in the tree consumes those filenames (the curl|sh installer generates its own viamin completions install).Verification
Locally, against
cargo build -p minimal:min completions print {bash,zsh,fish}— all three emit a shim, exit 0.min completions bash— reproduces the run's exact error.min, confirming the filename change.release.ymlre-parsed as YAML.The step itself only runs on a release dispatch, so the real proof is the next release run — a
dry_run: truedispatch exercises this step (it precedes the dry-run branch) without publishing anything.Note
The release job's CLI invocations have no pre-merge coverage; a breaking CLI change lands and only a release run finds out. Worth a follow-up guard, out of scope here.
🤖 Generated with Claude Code
Note
Fix
completions printcall and output filenames forminbinary in release jobThe release job's "Generate completions" step was calling
completions <shell>instead ofcompletions print <shell>for the minimal binary, and writing files namedminimal,_minimal, andminimal.fishinstead ofmin,_min, andmin.fish. This fixes both issues in release.yml.Macroscope summarized b6384c7.