fix: name the full exec-channel allowlist in the session attach -c docs - #1110
Conversation
Three docs stated that the non-interactive `min session attach -c` channel accepts only `min run` invocations. The daemon's exec handler also accepts `min package build [args...]` and `min check [args...]` (crates/minimald/src/exec.rs), so the docs understated the allowlist. List all three accepted forms in cli-min.md, agents.md, and sessions.md. Fixes #1067
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
|
|
hide = true on AttachArgs::command (#1071) was silently reverted by commit 64a0764, an unrelated help-text reformat -- the same collateral-clobber pattern #1071 itself had to repair once already. Restore it, along with the "hidden escape hatch" non-TTY error wording that shipped with it. This PR went the opposite direction from a hidden flag: it documented the full min run/min package build/min check allowlist in docs/concepts/sessions.md, docs/guide/agents.md, and docs/reference/cli-min.md. Since -c/--command is a hidden legacy escape hatch and not a general remote shell, remove those mentions instead of expanding them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The footgun note still spelled out the exact min run/min package build/min check allowlist, which is itself advertising a hidden flag. Keep the warning (don't treat -c as a general shell) and the source pointer, drop the enumerated command list. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The non-TTY error was still advertising the hidden --command escape hatch to every interactive caller who hit it -- inconsistent with hiding the flag everywhere else. Drop the mention; it only ever fires on the interactive path (command.is_none()), so it was pushing newcomers toward a flag we deliberately don't document. Update the one test that asserted on the old wording. Also drop the AGENTS.md footgun bullet entirely per feedback -- no partial version, just remove it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Fixes #1067
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABKsignQ
Three user-facing docs said the
min session attach -cexec channelaccepts only
min runinvocations, but the daemon's exec handler(crates/minimald/src/exec.rs) also accepts
min package build [args...]and
min check [args...]. This names all three accepted forms incli-min.md, agents.md, and sessions.md. #1062 (hide
-cfrom--help)is closed but the flag stays functional, so keeping the docs accurate is
the right resolution of that interaction.
Verification
cargo fmt --all --check — clean, exit 0
cargo clippy --workspace --locked -- -D warnings — Finished, exit 0
cargo build --workspace --locked — Finished in 4m 37s, exit 0
cargo test --workspace --locked — all workspace tests passed, 0 failed, exit 0
Note
Hide
-c/--commandflag frommin session attachhelp and remove it from docs-c/--commandoption onmin session attachas hidden in lib.rs so it no longer appears in generated CLI help, while keeping the flag functional.--commandfrom cli-min.md, sessions.md, agents.md, and AGENTS.md.--commandas an alternative.Macroscope summarized 35185c1.