fix: default console tracing filter to warn - #1129
Conversation
The console subscriber fell back to EnvFilter::new("info") when
RUST_LOG was unset, so every min command painted internal
daemon-spawn INFO plumbing into the user's terminal around the
CLI's intended output. Demote the fallback to warn; the RUST_LOG
override path and the topiary=off/libcgroups=off directives are
unchanged, and WARN and ERROR still render.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
norrietaylor
left a comment
There was a problem hiding this comment.
Reviewed: scope, clobber, correctness, CI. Approving.
Scope — one file, one line. crates/minimal/src/main.rs.
No clobber — the only removal is the line being changed. Checked specifically against #1114, which also touched main.rs and was partially reverted by two earlier patch PRs: pub mod theme; and the is_terminal() prompt logic are both untouched here.
Correctness — the change is inside EnvFilter::try_from_default_env().unwrap_or_else(...), i.e. the fallback default only. RUST_LOG still overrides, so anyone wanting INFO sets it explicitly. That is the right layer: it stops INFO spans painting into every user's terminal without removing the ability to get them. The topiary=off and libcgroups=off directives are preserved.
CI — 24/24 green.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABK6GjKA
The
minCLI's console tracing subscriber fell back to aninfoEnvFilter wheneverRUST_LOGwas unset, so every command painted internal daemon-spawn INFO plumbing into the user's terminal around the CLI's intended output. This demotes the single shared fallback filter towarn, so a cold-startmin lsshows no INFO lines whileRUST_LOG=inforestores them. TheRUST_LOGoverride path and thetopiary=off/libcgroups=offdirectives are untouched, WARN and ERROR still render, and the on-disk daemon logs themin bugbundle reads are unaffected since they are written by a separate file-log layer.Verification
cargo fmt --all --check — clean
cargo clippy --workspace --locked -- -D warnings — exit 0, no warnings
cargo build --workspace --locked — Finished, exit 0
cargo test --workspace --locked — all suites passed, exit 0
Note
Change default console tracing filter level from
infotowarnUpdates the default
EnvFilterlevel in main.rs frominfotowarnwhenRUST_LOGis not set. Behavioral Change: applications will no longer emitinfo-level logs by default.Macroscope summarized 9901a17.