Skip to content

Cargo.{lock,toml}: update deps - #177

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/checkers
May 1, 2026
Merged

Cargo.{lock,toml}: update deps#177
twitchyliquid64 merged 1 commit into
mainfrom
tom/checkers

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented May 1, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Revert
    • Temporarily adjusted a core dependency source to a specific commit while awaiting the next upstream release.
    • No user-facing functionality changed; existing formatting feature remains enabled and compatibility for current workflows is preserved.

@coderabbitai

coderabbitai Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 941be010-52c4-4328-9a6e-cb7330c015f5

📥 Commits

Reviewing files that changed from the base of the PR and between de5ab00 and e15c0b1.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • Cargo.toml
📝 Walkthrough

Walkthrough

The nickel-lang-core workspace dependency is switched from a crates.io version pin (0.17.0) to a git dependency pinned to a specific commit revision (rev = "3a399233dcb5b5e8610a1245eeb171c29787a903"), retaining default-features = false and features = ["format"]; comment notes this is temporary until 0.18 is released.

Changes

Cohort / File(s) Summary
Dependency Source Update
Cargo.toml		 Replaced nickel-lang-core = { version = "0.17.0", default-features = false, features = ["format"] } with a git-sourced declaration git = "https://github.com/nickel-lang/nickel.git", rev = "3a399233dcb5b5e8610a1245eeb171c29787a903". Feature flags unchanged; comment added about temporary revert.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • bryan-minimal
  • msample

Poem

🐰 I hopped to the Cargo, nose in the log,

Pulled a commit from the deep, not the registry fog.
A temporary fix on a branch I adore,
Until v0.18 opens its stable door. 🥕✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Cargo.{lock,toml}: update deps' is vague and generic, using non-descriptive terms that don't convey meaningful information about the specific change. Consider a more descriptive title that specifies the actual dependency change, such as 'Pin nickel-lang-core to git revision pending 0.18 release' or 'Switch nickel-lang-core from crates.io to git dependency'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tom/checkers

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

bryan-minimal
bryan-minimal approved these changes May 1, 2026
View reviewed changes

@bryan-minimal bryan-minimal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twitchyliquid64
twitchyliquid64 merged commit b3eeb8a into main May 1, 2026
8 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/checkers branch May 1, 2026 23:11
@coderabbitai coderabbitai Bot mentioned this pull request May 22, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jun 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryan-minimal bryan-minimal bryan-minimal approved these changes
@evanspearman evanspearman Awaiting requested review from evanspearman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @bryan-minimal