Skip to content

[worker:deadcode:rust] Remove unused deps from minimal2 and minimald - #232

Closed
gominimal-aw-bot[bot] wants to merge 1 commit into
mainfrom
chore/remove-unused-deps-229-abd81d16083aa8ea
Closed

[worker:deadcode:rust] Remove unused deps from minimal2 and minimald#232
gominimal-aw-bot[bot] wants to merge 1 commit into
mainfrom
chore/remove-unused-deps-229-abd81d16083aa8ea

Conversation

@gominimal-aw-bot

@gominimal-aw-bot gominimal-aw-bot Bot commented May 26, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Drops 6 confirmed-unused dependencies identified in issue #229:

Crate Removed dep Reason
crates/minimal2 dirs Not referenced in src/main.rs
crates/minimal2 futures Not referenced in src/main.rs
crates/minimal2 tokio-util Not referenced in src/main.rs
crates/minimal2 tracing Not referenced in src/main.rs (only tracing-subscriber is used)
crates/minimald futures Not referenced in any source file
crates/minimald tokio-util Not referenced in any source file

Skipped candidates (remote-proto — 6 prost/tonic deps): false positives for a proto-codegen crate that uses them in build.rs (consistent with previous worker PRs #225/#226).

minimald's dirs and tracing were NOT removed — both are actively used (dirs::cache_dir() and tracing::info!).

Verification: cargo build --workspace --all-targets, cargo fmt --all --check, cargo clippy --workspace --all-targets, cargo test --workspace --all-targets, and cargo build --workspace --all-targets --locked all pass.

Closes #229

Generated by Chore-issue worker agent (side-repo-ops operator) · ● 14M · ◷

Summary by CodeRabbit

  • Chores
    • Streamlined project dependencies by removing unused packages from workspace configurations, reducing build complexity and improving dependency management.

Review Change Stack

@gominimal-aw-bot
Remove unused deps from minimal2 and minimald
316e4be 
Drops 4 unused dependencies from crates/minimal2 (dirs, futures,
tokio-util, tracing) and 2 from crates/minimald (futures, tokio-util),
all confirmed unused by source inspection.

Skipped remote-proto prost/tonic stack (6 deps) — false positives for
a proto-codegen crate that uses them in build.rs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ee50a212-0fae-4c72-92a7-663c345daf8f

📥 Commits

Reviewing files that changed from the base of the PR and between 992f514 and 316e4be.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • crates/minimal2/Cargo.toml
  • crates/minimald/Cargo.toml
💤 Files with no reviewable changes (2)
  • crates/minimald/Cargo.toml
  • crates/minimal2/Cargo.toml
📝 Walkthrough

Walkthrough

This PR removes unused workspace-mapped dependencies from two crate manifests. minimal2 drops dirs, futures, tokio-util, and tracing while retaining tokio. minimald removes futures and tokio-util while keeping russh, serde, and tokio. Changes address issue #229 triage findings from cargo-machete.

Changes

Unused Dependency Cleanup

Layer / File(s) Summary
Remove unused workspace dependencies
crates/minimal2/Cargo.toml, crates/minimald/Cargo.toml		 Removes unused dirs, futures, tokio-util, and tracing from minimal2; removes futures and tokio-util from minimald. Both crates retain their essential workspace dependencies (tokio in both; russh and serde in minimald).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • gominimal/minimal#227: Scaffolded the minimal2 and minimald crates with these workspace-mapped dependencies, which this PR now cleans up.

Suggested labels

dependencies, rust

Suggested reviewers

  • norrietaylor
  • twitchyliquid64

Poem

A rabbit hops through dep-land clean,
Unused packages banished from the scene.
Tokio thrives, but futures goes to rest,
Machete's blade has done its best! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing unused dependencies from two crates (minimal2 and minimald), directly matching the changeset content.
Linked Issues check ✅ Passed The PR successfully addresses the primary coding objectives from issue #229: removing 4 unused deps from minimal2 and 2 from minimald, while appropriately excluding false positives.
Out of Scope Changes check ✅ Passed All changes are directly aligned with the scope of issue #229; only unused dependency removals were made to the specified crates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@norrietaylor

norrietaylor commented Jun 1, 2026

Copy link
Copy Markdown
Member

Closing - minimal2 is still scaffolding

@norrietaylor
norrietaylor deleted the chore/remove-unused-deps-229-abd81d16083aa8ea branch July 23, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@norrietaylor