Skip to content

chore(mctx): set cache dir to avoid /tmp mount settings failing tests - #370

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/fix
Jun 8, 2026
Merged

chore(mctx): set cache dir to avoid /tmp mount settings failing tests#370
twitchyliquid64 merged 1 commit into
mainfrom
tom/fix

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jun 8, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Updated integration tests to use explicit cache directory configuration.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7bfe9652-53a6-4af0-8ce1-3f3dbf310023

📥 Commits

Reviewing files that changed from the base of the PR and between 29501d0 and 1ca5977.

📒 Files selected for processing (1)
  • crates/mctx/src/lib.rs
📝 Walkthrough

Walkthrough

Two integration tests in crates/mctx/src/lib.rs are updated to configure an explicit cache directory via ConfigBuilder::with_cache_dir. Both task_env and task_resolve_string_interpolation now create a separate temporary cache directory and pass it to the config builder instead of using the default cache location.

Changes

Test Cache Directory Configuration

Layer / File(s) Summary
Explicit cache directory configuration in tests
crates/mctx/src/lib.rs		 task_env and task_resolve_string_interpolation tests now create a separate temporary cache directory alongside state and configure it via ConfigBuilder::with_cache_dir instead of relying on default cache location.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • gominimal/minimal#292: The main PR's test updates directly exercise the new separate cache directory support introduced in PR #292.

Suggested reviewers

  • evanspearman

Poem

🐰 A test that cached with care,
Now picks its own directory fair,
No defaults assumed,
Configuration bloomed,
Two tests harmonize in the air! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: configuring cache directories in mctx tests to prevent /tmp mount-related failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@twitchyliquid64
twitchyliquid64 enabled auto-merge (rebase) June 8, 2026 21:53
@twitchyliquid64
twitchyliquid64 merged commit 1b669b7 into main Jun 8, 2026
19 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/fix branch June 8, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norrietaylor norrietaylor norrietaylor approved these changes
@evanspearman evanspearman Awaiting requested review from evanspearman
@bryan-minimal bryan-minimal Awaiting requested review from bryan-minimal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @norrietaylor