chore: re-arranged the code in the sessions module to prepare for theclient/daemon split - #427

Walkthrough

Restructures the sessions crate by introducing core and client sub-module hierarchies. Previously flat top-level modules (vars.rs, policy.rs, patches.rs, expansion.rs, etc.) are consolidated into core/{primitives,decision,policy,source,expansion,lifecyclehook,loadout} and client/{composer,enumerate,hooks}. The crate's public module surface is updated to export the new hierarchy, and all dependent types and functions are rewired to use the restructured import paths.

Changes

Sessions crate module restructure

Sequence Diagram(s)

sequenceDiagram
  participant App
  participant Composer
  participant ResolveVars
  participant PolicyHooks
  participant ExpandPatch
  participant EnumerateFiles
  App->>Composer: resolve(provenanced_items)
  Composer->>ResolveVars: resolve per-domain vars
  ResolveVars->>ResolveVars: check policy (ignore/deny/allow)
  alt needs approval
    ResolveVars->>PolicyHooks: on_var_unapproved(Unapproved)
    PolicyHooks-->>ResolveVars: HookResult::Decided or Abort
  end
  Composer->>ExpandPatch: expand_patch_sources
  ExpandPatch->>ExpandPatch: call expand_source(VarLookup)
  alt expansion error
    ExpandPatch-->>Composer: Err(ExpandError)
  end
  Composer->>EnumerateFiles: enumerate_patch_files
  EnumerateFiles->>EnumerateFiles: walk, canonicalize, compute_dest
  alt walk/canonicalize error
    EnumerateFiles-->>Composer: Err(ResolveError::PatchWalk)
  end
  Composer-->>App: Ok(resolved session) or Err

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related issues

• gominimal/inbox#198: Requires the new Source enum with Project and Package variants in crate::core::source and the moved Composable trait in crate::client::composer to wire project and package contributors into the resolver architecture.

Possibly related PRs

• gominimal/minimal#348: Both PRs modify the sessions "composability/resolution" pipeline, especially the composer/policy-hook/patch-enumeration code paths, with this main PR refactoring those same components to use the new core policy/provenance/expansion primitives.
• gominimal/minimal#389: Shares the same sessions "var expansion + path canonicalization" pipeline, especially the symlink-aware patch enumeration via PatchFile carrying link_path/target_path and expansion of patch-source patterns.

Suggested reviewers

• twitchyliquid64
• norrietaylor

Poem

🐇 "My modules were scattered, a flat tangled mess,
Now core and client bring order and rest.
Source tracks provenance, Decision decides,
PolicyHooks callback wherever code hides.
With enumerate_patch_files walking the tree,
The sessions crate hops along neatly—like me!" 🌿

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}