feat(sessions): wire form types for client/daemon session creation communication - #443

Walkthrough

Introduces a complete wire-protocol layer for multi-round client/daemon session creation. Adds JSON-serializable primitive types, a WireError envelope, WireVarVerdict/WirePatchVerdict enums, and the full SessionCreateRequest/ContributionResponse/ContributionVerdict/Abort/SessionStep message set. Registers three new OneshotSshRpc marker structs (SessionCreate, SubmitVerdict, SessionAbort) in minimald-rpc.

Changes

Multi-round session RPC wire protocol

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant minimald-rpc
  participant Daemon

  rect rgba(70, 130, 180, 0.5)
    note over Client,Daemon: Session open
    Client->>minimald-rpc: SessionCreate (SessionCreateRequest)
    minimald-rpc->>Daemon: forward via OneshotSshRpc
    Daemon-->>Client: Errorable<SessionStep::Round(ContributionResponse)>
  end

  rect rgba(60, 179, 113, 0.5)
    note over Client,Daemon: Verdict rounds
    loop until ContributionResponse.complete == true
      Client->>minimald-rpc: SubmitVerdict (ContributionVerdict)
      minimald-rpc->>Daemon: forward via OneshotSshRpc
      Daemon-->>Client: Errorable<SessionStep::Round> or SessionStep::Fault(WireError)
    end
  end

  rect rgba(205, 92, 92, 0.5)
    note over Client,Daemon: Abort (optional)
    Client->>minimald-rpc: SessionAbort (Abort + AbortReason)
    minimald-rpc->>Daemon: forward via OneshotSshRpc
    Daemon-->>Client: Errorable<()>
  end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• gominimal/minimal#420: Established the OneshotSshRpc contract and RPC_SUBSYSTEM_PREFIX in crates/minimald-rpc/src/lib.rs that the three new RPC marker structs (SessionCreate, SubmitVerdict, SessionAbort) directly implement.

Suggested reviewers

• 0chroma
• norrietaylor

Poem

🐇 Hoppity-hop through the wire we go,
Primitives, verdicts, and errors in tow.
SessionCreate starts the round-trip dance,
SubmitVerdict gives each pending var a chance.
SessionAbort if the warren runs dry—
A JSON-tagged protocol waving goodbye! ✨

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}