revert(minvmd): back out abandoned gvproxy networking spec (#404) by norrietaylor · Pull Request #477 · gominimal/minimal

norrietaylor · 2026-06-19T18:35:25Z

Reverts the merged work from the abandoned tracking issue #404.

What this reverts

PR feat(minvmd): add net module with NetworkMode and gvproxy spawn #463 — crates/gvproxy crate, crates/minvmd/src/net.rs, and the Cargo workspace/dep wiring (clean git revert of ff6a212).
Spec and architecture docs: docs/specs/03-spec-minvmd-networking-gvproxy/ (added by docs(spec-minvmd-networking-gvproxy): minvmd networking — gvproxy userspace net for VM sessions #407, docs(arch-minvmd-networking-gvproxy): minvmd networking — gvproxy userspace net for VM sessions #445).

Why

#404 wedged: the task decomposition split State.gvproxy_pid (Task 1.3) from its run.rs constructors (Task 1.2) into independent sibling tasks, so neither PR compiled on macOS alone. The spec was abandoned rather than rescued.

Safety

No external dependents: only crates/minvmd referenced the gvproxy crate; sandbox2 wiring was deferred and never landed. Workspace manifest validates after revert (cargo metadata clean).

Status of the tree

Issues closed: feature: minvmd networking — gvproxy userspace net for VM sessions #404, Unit 1: gvproxy child spawn, lifecycle, and reap #450, Unit 2: libkrun passt/virtio-net FFI and VmConfig integration #451, Unit 3: Network allowlist enforcement hook #452, Integrate gvproxy lifecycle into run_foreground #454, Add gvproxy_pid to State #455, Add krun_set_passt_fd FFI bindings #456, Wire krun_set_passt_fd into VmConfig and vmm_child #457, Add NetworkPolicy and enforcement hook #458.
PRs closed unmerged: feat(minvmd-net): add network policy enforcement hook #471, feat(minvmd): add gvproxy_pid to State #473.
Task 1.1's merged code is what this PR removes.

Summary by CodeRabbit

Refactor
- Removed gvproxy crate and related networking support from the workspace
- Removed network mode configuration and resolution utilities
Documentation
- Removed gvproxy networking architecture specification documentation

…wn (#463)" This reverts commit ff6a212.

coderabbitai · 2026-06-19T18:35:39Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cf963eff-6c19-4324-a5e4-33643a2e18ae

📥 Commits

Reviewing files that changed from the base of the PR and between ff6a212 and 8cd98fc.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (8)

Cargo.toml
crates/gvproxy/Cargo.toml
crates/gvproxy/src/lib.rs
crates/minvmd/Cargo.toml
crates/minvmd/src/lib.rs
crates/minvmd/src/net.rs
docs/specs/03-spec-minvmd-networking-gvproxy/03-spec-minvmd-networking-gvproxy.md
docs/specs/03-spec-minvmd-networking-gvproxy/architecture.md

💤 Files with no reviewable changes (8)

crates/minvmd/src/lib.rs
crates/gvproxy/Cargo.toml
docs/specs/03-spec-minvmd-networking-gvproxy/03-spec-minvmd-networking-gvproxy.md
docs/specs/03-spec-minvmd-networking-gvproxy/architecture.md
crates/gvproxy/src/lib.rs
Cargo.toml
crates/minvmd/Cargo.toml
crates/minvmd/src/net.rs

📝 Walkthrough

Walkthrough

Removes the crates/gvproxy crate entirely from the workspace and deletes crates/minvmd/src/net.rs along with all related public exports, dependencies, and spec documentation. The minvmd crate no longer depends on or re-exports gvproxy networking functionality.

Changes

gvproxy crate and minvmd networking removal

Layer / File(s)	Summary
Workspace and crate manifest cleanup `Cargo.toml`, `crates/minvmd/Cargo.toml`, `crates/minvmd/src/lib.rs`	Removes `crates/gvproxy` from the workspace `members` array, deletes its `[workspace.dependencies]` entry, drops the `gvproxy.workspace = true` dependency from `minvmd`, and removes the `pub mod net;` re-export from `minvmd`'s crate root.
gvproxy crate source deleted `crates/gvproxy/Cargo.toml`, `crates/gvproxy/src/lib.rs`	Deletes the `gvproxy` crate package manifest and its entire `lib.rs`, which contained `gvproxy_bin`, `spawn_gvproxy`, and their unit tests.
minvmd net module deleted `crates/minvmd/src/net.rs`	Deletes `NetworkMode` enum, `resolve_net_mode()`, `gvproxy_bin()`, the `pub use gvproxy::spawn_gvproxy` re-export, and all associated unit tests.
Spec documentation removed `docs/specs/03-spec-minvmd-networking-gvproxy/...`	Deletes the gvproxy networking spec (`03-spec-minvmd-networking-gvproxy.md`) and its architecture document (`architecture.md`).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

gominimal/minimal#407: Introduced the minvmd/gvproxy networking spec documentation that this PR deletes.
gominimal/minimal#445: Introduced the gvproxy-based minvmd networking implementation (crates/gvproxy and minvmd::net) and architecture spec that this PR removes.
gominimal/minimal#463: Previously introduced the gvproxy crate, minvmd::net, and the NetworkMode/spawn_gvproxy helpers that this PR deletes.

Poem

🐇 Snip snip snip, the proxy is gone,
No gvproxy crate to carry along.
The net module vanished, the specs swept away,
The workspace is lighter and tidy today.
Some code must depart so new roots can grow —
A clean slate for networking's next show! 🌱

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: reverting the gvproxy networking implementation and removing its specification.
Linked Issues check	✅ Passed	The PR successfully reverts the gvproxy feature work described in `#404`, removing the crate, module implementations, and associated documentation as intended.
Out of Scope Changes check	✅ Passed	All changes are directly related to reverting the gvproxy feature and its documentation; no unrelated modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

norrietaylor added 2 commits June 19, 2026 11:34

Revert "feat(minvmd): add net module with NetworkMode and gvproxy spa…

1a1e409

…wn (#463)" This reverts commit ff6a212.

revert(minvmd): remove abandoned gvproxy networking spec docs (#404)

8cd98fc

msample approved these changes Jun 19, 2026

View reviewed changes

norrietaylor merged commit a78a6d6 into main Jun 19, 2026
46 checks passed

norrietaylor deleted the revert/404-minvmd-gvproxy-networking branch June 19, 2026 18:46

This was referenced Jun 21, 2026

docs(spike): gvproxy v0.8.9 switch-attachment protocol for DM2 #512

Merged

feat(minvmd): extend per-VM gvproxy to full PTask switch with vsock shuttle #522

Merged

fix(minvmd,minimald): subnet validation, attached_count lifecycle, tokio::fs #537

Merged

Navigation Menu

Uh oh!

revert(minvmd): back out abandoned gvproxy networking spec (#404) - #477

revert(minvmd): back out abandoned gvproxy networking spec (#404)#477
norrietaylor merged 2 commits into
mainfrom
revert/404-minvmd-gvproxy-networking

norrietaylor commented Jun 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 19, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

norrietaylor commented Jun 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this reverts

Why

Safety

Status of the tree

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

norrietaylor commented Jun 19, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 19, 2026 •

edited

Loading