docs(spikes): fix math error and UAPI protocol name in wireguard spike - #490
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThree factual corrections applied to the WireGuard implementation spike document: the wireguard-go subprocess integration socket is relabeled from a JSON configuration socket to a UAPI socket; the boringtun maintenance gap is revised from ~18 months to ~30 months (~2.5 years); and the risk-register action item is updated to match the ~30-month cadence with the 0.6.0 (July 2023) → 0.7.0 (January 2026) version date range. ChangesWireGuard Spike Document Factual Corrections
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Two post-merge correctness issues found by sdd-review on PR #488:
Changes
MEDIUM — Arithmetic fix (line 88 + action item 4)
The boringtun release gap (0.6.0 July 2023 → 0.7.0 January 2026) is ~30 months (~2.5 years), not ~18 months. The arithmetic:
The incorrect figure propagated into action item 4's risk-register checkpoint: "re-evaluate if no version is released within 18 months of the prior release." That threshold was calibrated against the wrong gap and would have triggered for any 19-month silence even though the historical gap was 30 months. Both occurrences are corrected.
LOW — Protocol name fix (line 71)
wireguard-go's subprocess interface is the WireGuard UAPI protocol — a line-based key=value text protocol over a Unix socket — not a "JSON configuration socket." Updated to "UAPI socket (a line-based key=value text protocol over a Unix socket)" for accuracy.
Proof
File assertion:
docs/spikes/2026-06-20-wireguard-implementation.mdcontains no18-monthorJSON configurationtext after this change, and contains~30-month gapat lines 89 and 250, andUAPI socketat line 71.Refs #488
Summary by CodeRabbit